Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TagSpecifications to ec2:CreateNetworkInterface only when len > 0 #14571

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Add TagSpecifications to ec2:CreateNetworkInterface only when len > 0 #14571

merged 1 commit into from
Jan 12, 2021

Conversation

ungureanuvladvictor
Copy link
Member

@ungureanuvladvictor ungureanuvladvictor commented Jan 11, 2021 •
edited

If no tags are being passed we currently still set the TagSpecification
which results in a 4xx from the ec2 API:

Unable to create interface on instance: unable to create ENI operation error EC2: CreateNetworkInterface, https response error StatusCode: 400, RequestID: 328945ae-c171-4987-b829-be5e8cd3e792, api error InvalidParameter: Tag specification must have at least one tag

Fixes 02bf3ba.

Signed-off-by: Vlad Ungureanu vladu@palantir.com

@ungureanuvladvictor
Add TagSpecifications to ec2:CreateNetworkInterface only when len > 0
0c3c4dd 
If no tags are being passed we currently still set the TagSpecification
which results in a 4xx from the ec2 API.

Fixes 02bf3ba.

Signed-off-by: Vlad Ungureanu <vladu@palantir.com>
@ungureanuvladvictor ungureanuvladvictor requested a review from a team as a code owner January 11, 2021 05:15
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 11, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 11, 2021
@ungureanuvladvictor ungureanuvladvictor added the release-note/misc This PR makes changes that have no direct user impact. label Jan 11, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 11, 2021
@ungureanuvladvictor
Copy link
Member Author

test-me-please

@ungureanuvladvictor
Copy link
Member Author

retest-4.9

@ungureanuvladvictor ungureanuvladvictor mentioned this pull request Jan 11, 2021
Closed
@ungureanuvladvictor
Copy link
Member Author

retest-4.9

@aanm aanm merged commit 4e7fde7 into master Jan 12, 2021
@aanm aanm deleted the vladu/fix-ec2-tagging branch January 12, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@tgraf tgraf Awaiting requested review from tgraf

Assignees

@tgraf tgraf

Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ungureanuvladvictor @christarazi @tgraf @aanm