Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Update list of Jenkins jobs #14592

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Conversation

twpayne
Copy link
Contributor

@twpayne twpayne commented Jan 12, 2021

This updates the list of Jenkins jobs that can be triggered with trigger phrases in the documentation to more closely match the jobs currently running in Jenkins.

I'm not sure if the trigger phrases are correct.

@twpayne twpayne added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels Jan 12, 2021
@twpayne twpayne requested a review from pchaigno January 12, 2021 15:51
@twpayne twpayne requested review from a team as code owners January 12, 2021 15:51
@twpayne twpayne requested a review from qmonnet January 12, 2021 15:51
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 12, 2021
@qmonnet qmonnet requested a review from nebril January 13, 2021 09:29
@qmonnet qmonnet removed their assignment Jan 13, 2021
Comment on lines 211 to 213
| `Ginkgo-CI-Tests-k8s1.13-Pipeline <https://jenkins.cilium.io/job/Ginkgo-CI-Tests-k8s1.13-Pipeline/>`_ | test-missed-k8s | No |
+----------------------------------------------------------------------------------------------------------------+-------------------+--------------------+
| `Cilium-Ginkgo-Test-k8s <https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-k8s/>`_ | test-missed-k8s | Yes |
| `Ginkgo-CI-Tests-k8s1.20-Pipeline <https://jenkins.cilium.io/job/Ginkgo-CI-Tests-k8s1.20-Pipeline/>`_ | test-missed-k8s | Yes |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't look right... test-missed-k8s runs k8s versions from 1.14-1.19

@@ -194,29 +194,27 @@ illustrating which subset of tests the job runs.
+----------------------------------------------------------------------------------------------------------------+-------------------+--------------------+
| Jenkins Job | Trigger Phrases | Required To Merge? |
+================================================================================================================+===================+====================+
| `K8s-1.20-kernel-4.9 <https://jenkins.cilium.io/job/Cilium-PR-K8s-newest-kernel-4.9/>`_ | test-me-please, | Yes |
| `Cilium-PR-K8s-1.19-kernel-4.9 <https://jenkins.cilium.io/job/Cilium-PR-K8s-1.19-kernel-4.9/>`_ | test-me-please, | Yes |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right as well, test-me-please runs k8s 1.20 + kernel 4.9, k8s 1.19 + kernel 4.19 and k8s 1.13 + kernel net-next

Signed-off-by: Tom Payne <tom@isovalent.com>
@twpayne
Copy link
Contributor Author

twpayne commented Jan 15, 2021

This should now be correct with respect to the trigger phrases too. I've removed the pipeline jobs from the list as they are run periodically rather than being triggered by PRs.

@aanm aanm removed their assignment Jan 18, 2021
@aanm aanm added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 18, 2021
@gandro gandro merged commit c9f54e3 into master Jan 18, 2021
@gandro gandro deleted the pr/twpayne/jenkins-jobs-doc branch January 18, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants