arp: Add retries to arping #14601
Merged
arp: Add retries to arping #14601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
pending-review
area/daemon
|
test-me-please |
|
retest-4.19 |
aanm
requested changes
Jan 14, 2021
fristonio
approved these changes
Jan 14, 2021
brb
force-pushed
the
pr/brb/retry-arping
branch
from
cbb040e
to
612d41f
Compare
It has been observed that sometimes arping fails with "i/o timeout". Further investigation [1] has shown that this happen due to the kernel not sending packets. Therefore, to mitigate the issue,try multiple times to send the request if the timeout error is encountered. [1]: #14125 (comment) Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
Previously all tests were green. Pushed only a comment change. Retrying the runtime suite to see whether the flake is not reintroduced. |
|
test-runtime |
1 similar comment
|
test-runtime |
|
@aanm Ran the test 3 times - all passed. |
aanm
approved these changes
Jan 18, 2021
|
Once cilium/arping#6 has been merged, I will manually backport to v1.8 and v1.9. |
This was referenced Jan 18, 2021
This was referenced May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been observed that sometimes arping fails with "i/o timeout".
Further investigation [1] has shown that this happen due to the kernel
not sending packets. Therefore, to mitigate the issue, try multiple times
to send the request if the timeout error is encountered.
[1]: #14125 (comment)
Currently, I'm not labeling it for backporting to v1.{8,9}, as I've opened a discussion whether we could backport the arp library too which would significantly reduce complexity of arping-related backports.