Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Tailor Brands to users #14605

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Added Tailor Brands to users #14605

merged 1 commit into from
Jan 14, 2021

Conversation

liorrozen
Copy link
Contributor

@liorrozen liorrozen commented Jan 13, 2021 •
edited

Signed-off-by: Lior Rozen liorr@tailorbrands.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

@liorrozen
Added Tailor Brands to users
e9a2e60 
Signed-off-by: Lior Rozen <liorr@tailorbrands.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 13, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 13, 2021
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Jan 13, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 13, 2021
@joestringer
Copy link
Member

Welcome and thanks for the contribution! The PR is marked as "draft", but it looks good to me. @liorrozen Are you OK to merge this?

@joestringer joestringer self-assigned this Jan 13, 2021
@liorrozen liorrozen marked this pull request as ready for review January 14, 2021 08:04
@liorrozen liorrozen requested a review from a team as a code owner January 14, 2021 08:04
@liorrozen
Copy link
Contributor Author

Hiya @joestringer - yes ready to merge now 👍 was waiting to make sure all the checks pass.

gandro
gandro approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gandro gandro merged commit 14e611d into cilium:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@joestringer joestringer joestringer approved these changes

Assignees

@joestringer joestringer

Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liorrozen @joestringer @gandro