Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go to 1.15.7 #14662

Merged
merged 1 commit into from
Jan 23, 2021
Merged

Update Go to 1.15.7 #14662

merged 1 commit into from
Jan 23, 2021

Conversation

tklauser
Copy link
Member

No description provided.

@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Jan 20, 2021
@tklauser tklauser requested a review from aanm January 20, 2021 11:01
@tklauser tklauser requested review from a team as code owners January 20, 2021 11:01
@tklauser tklauser requested a review from a team January 20, 2021 11:01
@tklauser tklauser requested a review from a team as a code owner January 20, 2021 11:01
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 20, 2021
@tklauser
Update Go to 1.15.7
df3abc7 
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser
Copy link
Member Author

test-me-please

@tklauser
Copy link
Member Author

tklauser commented Jan 20, 2021 •
edited

retest-gke

cluster locking issue: https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/4026/

@aanm aanm removed their assignment Jan 20, 2021
@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 21, 2021
@tklauser tklauser removed the request for review from michi-covalent January 21, 2021 09:00
@tklauser
Copy link
Member Author

tklauser commented Jan 21, 2021 •
edited

Received reviews from all assigned teams and CI passed. Marking as "ready to merge".

@tklauser
Copy link
Member Author

tklauser commented Jan 21, 2021 •
edited

retest-gke

Not sure why/how GKE tests were retriggered before this message. Thy previously were passing. Removed ready-to-merge for now.

@tklauser tklauser removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 21, 2021
kaworu
kaworu approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@kaworu kaworu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tklauser not completely related but: should we update alpine images to 3.13?

@tklauser
Copy link
Member Author

tklauser commented Jan 21, 2021 •
edited

retest-gke

scaling cluster failed: https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/4049/

@tklauser
Copy link
Member Author

@tklauser not completely related but: should we update alpine images to 3.13?

@kaworu Good point, thanks. Will send a separate PR doing that (and for cilium/hubble as well).

@tklauser
Copy link
Member Author

tklauser commented Jan 22, 2021 •
edited

retest-gke

scaling cluster failed: https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/4053/

@tklauser
Copy link
Member Author

tklauser commented Jan 22, 2021 •
edited

retest-gke

scaling cluster failed: https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/4060/

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 22, 2021
@aanm aanm merged commit 4c827bf into master Jan 23, 2021
@aanm aanm deleted the pr/tklauser/update-go-1.15.7 branch January 23, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twpayne twpayne twpayne approved these changes

@kaworu kaworu kaworu approved these changes

@rolinh rolinh rolinh approved these changes

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tklauser @twpayne @kaworu @rolinh @christarazi @aanm @michi-covalent