Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/helpers: fix GetBPFPacketsCount #14663

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Conversation

jibi
Copy link
Member

@jibi jibi commented Jan 20, 2021

Switch to the json output for the 'cilium bpf metrics list' command so
that we can reliably get the packets count regardless of how many spaces
are there in the description of the drop reason.

Signed-off-by: Gilberto Bertin gilberto@isovalent.com

Switch to the json output for the 'cilium bpf metrics list' command so
that we can reliably get the packets count regardless of how many spaces
are there in the description of the drop reason.

Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
@jibi jibi requested a review from a team as a code owner January 20, 2021 11:09
@jibi jibi requested review from a team, errordeveloper and aditighag January 20, 2021 11:09
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 20, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 20, 2021
@jibi jibi added the release-note/ci This PR makes changes to the CI. label Jan 20, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 20, 2021
@jibi
Copy link
Member Author

jibi commented Jan 20, 2021

test-me-please

@jibi jibi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 20, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 20, 2021
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 20, 2021
@rolinh rolinh merged commit e7aa5a5 into master Jan 21, 2021
@rolinh rolinh deleted the pr/jibi/fix-get-bpf-packets-count branch January 21, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants