Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: update release process #14672

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Conversation

aanm
Copy link
Member

@aanm aanm commented Jan 20, 2021

Add steps to sync projects during release process.

Signed-off-by: André Martins andre@cilium.io

Add steps to sync projects during release process.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Jan 20, 2021
@aanm aanm requested a review from a team as a code owner January 20, 2021 17:53
@aanm aanm requested a review from tklauser January 20, 2021 17:53
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 20, 2021
@aanm aanm requested a review from joestringer January 20, 2021 17:54
@aanm aanm removed the request for review from tklauser January 20, 2021 17:54
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

- [ ] (If applicable) Update the `cilium_version` and `cilium_tag` in
`examples/getting-started/Vagrantfile`
- [ ] Run `Documentation/check-crd-compat-table.sh vX.Y` and if needed, follow the
instructions.
- [ ] Commit all changes with title `Prepare for release vX.Y.Z`
- [ ] Submit PR (`contrib/release/submit-release.sh`)
- [ ] Execute `release --current-version X.Y.Z --next-dev-version X.Y.W` to automatically
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is release a custom binary or makefile target?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a binary of github.com/cilium/releases

@aanm aanm merged commit 1e099b5 into cilium:master Jan 21, 2021
- [ ] (If applicable) Update the `cilium_version` and `cilium_tag` in
`examples/getting-started/Vagrantfile`
- [ ] Run `Documentation/check-crd-compat-table.sh vX.Y` and if needed, follow the
instructions.
- [ ] Commit all changes with title `Prepare for release vX.Y.Z`
- [ ] Submit PR (`contrib/release/submit-release.sh`)
- [ ] Execute `release --current-version X.Y.Z --next-dev-version X.Y.W` to automatically
move any unresolved issues/PRs from old release project into the new
project. (`W` should be calculation of `Z+1`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to make this part of the start-release step so it's one less moving piece to think about.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we have the number z+1 in the current scripts though, that can be non-trivial to calculate in shell scripts :<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants