-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github: update release process #14672
Conversation
Add steps to sync projects during release process. Signed-off-by: André Martins <andre@cilium.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
- [ ] (If applicable) Update the `cilium_version` and `cilium_tag` in | ||
`examples/getting-started/Vagrantfile` | ||
- [ ] Run `Documentation/check-crd-compat-table.sh vX.Y` and if needed, follow the | ||
instructions. | ||
- [ ] Commit all changes with title `Prepare for release vX.Y.Z` | ||
- [ ] Submit PR (`contrib/release/submit-release.sh`) | ||
- [ ] Execute `release --current-version X.Y.Z --next-dev-version X.Y.W` to automatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is release
a custom binary or makefile target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a binary of github.com/cilium/releases
- [ ] (If applicable) Update the `cilium_version` and `cilium_tag` in | ||
`examples/getting-started/Vagrantfile` | ||
- [ ] Run `Documentation/check-crd-compat-table.sh vX.Y` and if needed, follow the | ||
instructions. | ||
- [ ] Commit all changes with title `Prepare for release vX.Y.Z` | ||
- [ ] Submit PR (`contrib/release/submit-release.sh`) | ||
- [ ] Execute `release --current-version X.Y.Z --next-dev-version X.Y.W` to automatically | ||
move any unresolved issues/PRs from old release project into the new | ||
project. (`W` should be calculation of `Z+1`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to make this part of the start-release step so it's one less moving piece to think about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we have the number z+1
in the current scripts though, that can be non-trivial to calculate in shell scripts :<
Add steps to sync projects during release process.
Signed-off-by: André Martins andre@cilium.io