Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add section in external etcd about identity-allocation-mode #14673

Merged
merged 1 commit into from Jan 25, 2021
Merged

docs: Add section in external etcd about identity-allocation-mode #14673

merged 1 commit into from Jan 25, 2021

Conversation

christarazi
Copy link
Member

Users have reported that they weren't aware of this option when using
external etcd. It is not required, but better to raise awareness.

@christarazi christarazi requested a review from a team as a code owner January 20, 2021 20:40
@christarazi christarazi added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. needs-backport/1.9 release-note/misc This PR makes changes that have no direct user impact. labels Jan 20, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 20, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 20, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 20, 2021
@christarazi christarazi force-pushed the pr/christarazi/clarify-external-etcd-docs-id-alloc branch from 1a158ff to b4c09df Compare January 20, 2021 20:42
@christarazi
docs: Add section for external etcd about identity-allocation-mode
3adec2a 
Users have reported that they weren't aware of this option when using
external etcd. It is not required, but better to raise awareness.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/clarify-external-etcd-docs-id-alloc branch from b4c09df to 3adec2a Compare January 20, 2021 20:49
@aanm aanm merged commit 424c3e4 into cilium:master Jan 25, 2021
@christarazi christarazi deleted the pr/christarazi/clarify-external-etcd-docs-id-alloc branch January 25, 2021 19:02
@joestringer joestringer mentioned this pull request Jan 28, 2021
Merged
@christarazi christarazi mentioned this pull request Feb 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@joestringer joestringer Awaiting requested review from joestringer

Assignees

@joestringer joestringer

Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christarazi @aanm @joestringer