bpf: Correctly use revalidate_data_pull() in do_decrypt() #14689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IPv6 path in do_decrypt() was already correctly using revalidate_data_pull(). The IPv4 path was node. If not enough headers were pull'ed, the call would fail which resulted in ESP packets not being detected correctly and thus not decrypted due to lacking the packet mark. This seems to be a regression introduced with the refactoring commit 9ed106a. Fixes: 9ed106a ("cilium: create lib for encryption") Suggested-by: John Fastabend <john.fastabend@gmail.com> Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
added
kind/bug
tgraf
added
the
kind/regression
|
test-me-please |
pchaigno
approved these changes
Jan 21, 2021
pchaigno
added
the
area/encryption
|
retest-gke |
christarazi
moved this from Needs backport from master
to Backport done to v1.9
in 1.9.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IPv6 path in do_decrypt() was already correctly using
revalidate_data_pull(). The IPv4 path was node. If not enough headers
were pull'ed, the call would fail which resulted in ESP packets not
being detected correctly and thus not decrypted due to lacking the
packet mark.
This seems to be a regression introduced with the refactoring commit
9ed106a. Only 1.9 is affected.
Fixes: 9ed106a ("cilium: create lib for encryption")
Suggested-by: John Fastabend john.fastabend@gmail.com