test: Respect cilium.holdEnvironment on DNS check #14695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DNS check is one of the first things we check when starting a new
test. As such, the following error is common in CI and local tests.
Kubernetes DNS did not become ready in time
In local tests however, when -cilium.holdEnvironment=true, the tests
don't pause after such failures. That is because we fail the test with
ginkgo.Fail instead of our wrapper function helpers.Fail. This commit
fixes it.
Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
area/CI
nebril
approved these changes
Jan 26, 2021
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple change, but it has annoyed me often enough during local testing: