hubble: Support --{last,since,until} on agent and debug events #14739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
added
release-note/misc
rolinh
reviewed
Jan 26, 2021
With the introduction of agent and debug events, this reader, while implementing the GetFlows API, actually now returns events which are different from flows. This commit renames the involved types and variables to reflect that. This commit contains no functional changes. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/hubble-fix-non-flows-request-collection
branch
from
741ddd7
to
a8c28ce
Compare
tklauser
reviewed
Jan 26, 2021
There was a problem hiding this comment.
Minor nit on the PR description/commit message:
This PR ensures that the Number, Until and Since filters on
the GetFlowsRequest are treated the same on agent and flow events as
they are on flow events.
I assume this should say "...the GetFlowsRequest are treated the same on agent and debug events as they are on flow events."?
rolinh
approved these changes
Jan 27, 2021
This commit ensures that the `Number`, `Until` and `Since` filters on the `GetFlowsRequest` are treated the same on agent and debug events as they are on flow events. Previously, the observer API would only stop reading from the ring buffer once it had collected enough flows. All interleaved debug and agent events were returned without proper accounting (assuming they were allows by the event type filter). This meant that if a request was only requesting agent and/or debug events, that it would try to dump all such events in the ring buffer. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/hubble-fix-non-flows-request-collection
branch
from
a8c28ce
to
44a05f5
Compare
|
test-me-please |
|
GKE failed to scale cluster https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/4146/ retest-gke |
This was referenced Jan 28, 2021
|
retest-runtime |
|
retest-4.9 |
tklauser
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the
Number,UntilandSincefilters onthe
GetFlowsRequestare treated the same on agent and debug events asthey are on flow events.
Previously, the observer API would only stop reading from the ring
buffer once it had collected enough flows. All interleaved debug and
agent events were returned without proper accounting (assuming they were
allows by the event type filter). This meant that if a request was only
requesting agent and/or debug events, that it would try to dump all such
events in the ring buffer.
The first commit in this PR is a simple refactor renaming
flowsReadertoeventsReader.It should not contain any functional changes.