health: Disable routing in BPF when per-endpoint routes are enabled #14741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a datapath configuration discrepancy between the health endpoint and other endpoints. ENABLE_ROUTING should be undefined if per-endpoint routes are enabled [1]; for the health endpoint, the macro is defined regardless of the settings. Quite surprisingly, I'm not aware of any bug caused by this oversight, although it probably requires one more template and full compilation than necessary when per-endpoint routes are enabled. 1 - https://github.com/cilium/cilium/blob/e463cfe80102486d1a3423b77f9c54afd0be94a2/daemon/cmd/endpoint.go#L309-L327 Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
sig/loader
|
test-me-please |
|
The cilium/health review should be covered by Joe's review, but GitHub didn't count it as such because I marked the PR as ready for reviews only after Joe reviewed. In any case, I think this is now ready to merge. |
pchaigno
added
the
ready-to-merge
joestringer
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a datapath configuration discrepancy between the health endpoint and other endpoints.
ENABLE_ROUTINGshould be undefined if per-endpoint routes are enabled; for the health endpoint, the macro is defined regardless of the settings.Quite surprisingly, I'm not aware of any bug caused by this oversight, although it probably requires one more template and full compilation than necessary when per-endpoint routes are enabled.