datapath/linux: Fix clang version regex check #14742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following error when the machine has clang 11.0.1 installed: ``` level=info msg="Cilium 1.9.90 0bffe8b 2021-01-26T11:16:34+01:00 go version go1.15.7 linux/amd64" subsys=daemon level=info msg="Envoy version check disabled" subsys=daemon level=fatal msg="clang: NOT OK" error="Invalid character(s) found in patch number \"1\\nTarget:\"" subsys=linux-datapath ``` The issue was that the regex pattern was matching only against " " and not any other kind of whitespace, especially newlines. Changing the regex to match against all whitespace, including newlines, the pattern is able to stop the match at the correct spot. The output it was trying to match against was: ``` clang version 11.0.1 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin ``` Signed-off-by: Chris Tarazi <chris@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
christarazi
added
area/misc
|
test-me-please |
brb
approved these changes
Jan 27, 2021
tklauser
approved these changes
Jan 27, 2021
jibi
approved these changes
Jan 27, 2021
|
retest-net-next hit #12511 https://jenkins.cilium.io/job/Cilium-PR-K8s-1.13-net-next/573/ |
christarazi
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following error when the machine has clang 11.0.1
installed:
The issue was that the regex pattern was matching only against " " and
not any other kind of whitespace, especially newlines. Changing the
regex to match against all whitespace, including newlines, the pattern
is able to stop the match at the correct spot. The output it was trying
to match against was:
Signed-off-by: Chris Tarazi chris@isovalent.com