Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend endpoint related interfaces #14743

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Extend endpoint related interfaces #14743

merged 2 commits into from
Feb 3, 2021

Conversation

aditighag
Copy link
Member

See commit description.

@aditighag aditighag requested review from a team January 27, 2021 00:25
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 27, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 27, 2021
@aditighag aditighag added the release-note/misc This PR makes changes that have no direct user impact. label Jan 27, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 27, 2021
christarazi
christarazi approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor optional comment if it makes sense

pkg/hubble/parser/getters/getters.go Outdated Show resolved Hide resolved
twpayne
twpayne reviewed Jan 27, 2021
View reviewed changes
pkg/policy/resolve_test.go Show resolved Hide resolved
pkg/policy/identifier_test.go Show resolved Hide resolved
@aditighag aditighag marked this pull request as draft January 27, 2021 15:44
@aditighag
test: Refactor interface implementation
d28135c 
Embed interface into a mock so that all the methods
are inherited, and only the relevant methods can be
implemented in tests in order to override real code.

Signed-off-by: Aditi Ghag <aditi@cilium.io>
@aditighag
daemon: Extend Endpoint related interfaces
94c9454 
External plugins can use these interfaces to get Endpoint
state.

Signed-off-by: Aditi Ghag <aditi@cilium.io>
@aditighag
Copy link
Member Author

aditighag commented Jan 27, 2021 •
edited

Travis CI run failed because of the rate limit issue. But one of the runs passed - https://travis-ci.com/github/cilium/cilium/jobs/477348687

anyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

@aditighag aditighag closed this Jan 27, 2021
@aditighag aditighag reopened this Jan 27, 2021
@aditighag aditighag marked this pull request as ready for review January 27, 2021 18:07
@aditighag
Copy link
Member Author

test-me-please

@aditighag
Copy link
Member Author

GKE test failed due to failure to scale - https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/4130/

@aditighag
Copy link
Member Author

test-gke

@aditighag
Copy link
Member Author

GKE test failed due to failure to scale - https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/4130/

Still failing with the same issue - https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/4149/console

@aditighag
Copy link
Member Author

test-gke

@aditighag aditighag added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 29, 2021
@aditighag aditighag requested a review from a team January 29, 2021 17:30
@aanm aanm added dont-merge/preview-only Only for preview or testing, don't merge it. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Jan 30, 2021
@aanm
Copy link
Member

aanm commented Jan 30, 2021

Blocking merging for now to discuss some fundamentals around this PR.

@aanm aanm added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/preview-only Only for preview or testing, don't merge it. labels Feb 2, 2021
@aditighag aditighag added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Feb 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 3, 2021
@tklauser tklauser merged commit 1b1686b into cilium:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twpayne twpayne twpayne approved these changes

@tklauser tklauser tklauser approved these changes

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

@glibsm glibsm Awaiting requested review from glibsm

@jrajahalme jrajahalme Awaiting requested review from jrajahalme

Assignees

@twpayne twpayne

@glibsm glibsm

@jrajahalme jrajahalme

Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@aditighag @aanm @twpayne @tklauser @christarazi @glibsm @jrajahalme