Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add note to open tcp:4244 for Hubble Relay #14758

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

youssefazrak
Copy link
Contributor

Hubble Relay will fail to connect to peers if a host firewall is blocking
tcp:4244. The documentation should contain a heads-up/note about this so that
users using a host firewall don't forget to open tcp:4244 when enabling
Hubble Relay.

Fixes: #14402

Signed-off-by: Youssef Azrak yazrak.tech@gmail.com

Hubble Relay will fail to connect to peers if a host firewall is blocking
tcp:4244. The documentation should contain a heads-up/note about this so that
users using a host firewall don't forget to open tcp:4244 when enabling
Hubble Relay.

Fixes: cilium#14402

Signed-off-by: Youssef Azrak <yazrak.tech@gmail.com>
@youssefazrak youssefazrak requested a review from a team as a code owner January 27, 2021 19:54
@youssefazrak youssefazrak requested review from a team, qmonnet and glibsm January 27, 2021 19:54
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 27, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 27, 2021
@youssefazrak youssefazrak marked this pull request as draft January 27, 2021 19:54
@glibsm glibsm requested review from rolinh and removed request for qmonnet January 27, 2021 21:07
@glibsm glibsm added the release-note/misc This PR makes changes that have no direct user impact. label Jan 27, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 27, 2021
@youssefazrak youssefazrak marked this pull request as ready for review January 27, 2021 22:06
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 28, 2021
@aanm aanm merged commit 7c6dff7 into cilium:master Jan 28, 2021
@youssefazrak youssefazrak deleted the doc_tcp_4244 branch January 28, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

doc: document that tcp:4244 needs to be open on the host to allow Relay to connect to peers
5 participants