-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify description of IPSec configuration format and encryption options #14760
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements! 🚀
Commit 058c007f4e75b22e37d9dd0e2543f62702704b7f does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@pchaigno how about now? Dropped pod-to-pod/host-to-host to avoid confusion. So that section is mostly untouched. Though it might be useful to describe all the cases but i'm to new to the project to cover it as you already observed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, looks better 🚀
For maintainer-s-little-helper to stop complaining, you'll need to squash your commits and add a Signed-off-by: Name <email.address>
to the commit message.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
All the changes as one commit with signed-off message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
Commit formatting and SOB tag are good now.
Signed-off-by: Andrey Devyatkin <andrey.devyatkin@fivexl.io>
Signed-off-by: Andrey Devyatkin andrey.devyatkin@fivexl.io
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Clarify description of IPSec configuration format and encryption options based on this conversation https://cilium.slack.com/archives/C1MATJ5U5/p1611678079108700