Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify description of IPSec configuration format and encryption options #14760

Merged
merged 1 commit into from
Jan 30, 2021

Conversation

Andrey9kin
Copy link
Contributor

Signed-off-by: Andrey Devyatkin andrey.devyatkin@fivexl.io

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Clarify description of IPSec configuration format and encryption options based on this conversation https://cilium.slack.com/archives/C1MATJ5U5/p1611678079108700

Clarify description of IPSec configuration format and encryption options

@Andrey9kin Andrey9kin requested a review from a team as a code owner January 27, 2021 20:42
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 27, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 27, 2021
@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-note/misc This PR makes changes that have no direct user impact. labels Jan 27, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 27, 2021
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements! 🚀

Documentation/gettingstarted/encryption.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/encryption.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/encryption.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/encryption.rst Outdated Show resolved Hide resolved
@maintainer-s-little-helper
Copy link

Commit 058c007f4e75b22e37d9dd0e2543f62702704b7f does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jan 28, 2021
@maintainer-s-little-helper

This comment has been minimized.

1 similar comment
@maintainer-s-little-helper

This comment has been minimized.

@maintainer-s-little-helper

This comment has been minimized.

@Andrey9kin
Copy link
Contributor Author

@pchaigno how about now? Dropped pod-to-pod/host-to-host to avoid confusion. So that section is mostly untouched. Though it might be useful to describe all the cases but i'm to new to the project to cover it as you already observed

Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks better 🚀

For maintainer-s-little-helper to stop complaining, you'll need to squash your commits and add a Signed-off-by: Name <email.address> to the commit message.

Documentation/gettingstarted/encryption.rst Outdated Show resolved Hide resolved
Documentation/gettingstarted/encryption.rst Outdated Show resolved Hide resolved
@maintainer-s-little-helper

This comment has been minimized.

1 similar comment
@maintainer-s-little-helper

This comment has been minimized.

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jan 28, 2021
@Andrey9kin
Copy link
Contributor Author

All the changes as one commit with signed-off message

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!
Commit formatting and SOB tag are good now.

Documentation/gettingstarted/encryption.rst Outdated Show resolved Hide resolved
Signed-off-by: Andrey Devyatkin <andrey.devyatkin@fivexl.io>
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 29, 2021
@aanm aanm merged commit 80b265c into cilium:master Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants