-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependabot: ignore grpc and miekg/dns updates #14790
Merged
aanm
merged 1 commit into
cilium:master
from
tklauser:pr/tklauser/dependabot-ignore-grpc
Jan 30, 2021
Merged
dependabot: ignore grpc and miekg/dns updates #14790
aanm
merged 1 commit into
cilium:master
from
tklauser:pr/tklauser/dependabot-ignore-grpc
Jan 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Jan 29, 2021
rolinh
approved these changes
Jan 29, 2021
No need for a full CI run as this PR only touches the dependabot config file. |
rolinh
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Jan 29, 2021
We cannot update the grpc beyond 1.29.1 until we bump etcd to 3.04, see cilium#13405 (comment), etcd-io/etcd#12124 and cilium#14787 (comment) for more information. We also ignore github.com/miekg/dns because we use our own fork of it via replace and it seems the long-term plan is to replace the DNS proxy with Envoy, see cilium#14790 (comment) Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
pr/tklauser/dependabot-ignore-grpc
branch
from
January 29, 2021 11:45
3569669
to
70cb16c
Compare
Sure, done. |
tklauser
changed the title
dependabot: ignore grpc updates
dependabot: ignore grpc and mikg/dns updates
Jan 29, 2021
aanm
approved these changes
Jan 29, 2021
tklauser
changed the title
dependabot: ignore grpc and mikg/dns updates
dependabot: ignore grpc and miekg/dns updates
Jan 29, 2021
rolinh
approved these changes
Jan 29, 2021
lyveng
pushed a commit
to lyveng/cilium
that referenced
this pull request
Mar 4, 2021
We cannot update the grpc beyond 1.29.1 until we bump etcd to 3.04, see cilium#13405 (comment), etcd-io/etcd#12124 and cilium#14787 (comment) for more information. We also ignore github.com/miekg/dns because we use our own fork of it via replace and it seems the long-term plan is to replace the DNS proxy with Envoy, see cilium#14790 (comment) Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot update the grpc beyond 1.29.1 until we bump etcd to 3.5.0, see
#13405 (comment), etcd-io/etcd#12124 and #14787 (comment) for more
information.
We also ignore github.com/miekg/dns because we use our own fork of it
via replace and it seems the long-term plan is to replace the DNS proxy
with Envoy, see #14790 (comment)