Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot: ignore grpc and miekg/dns updates #14790

Merged
merged 1 commit into from
Jan 30, 2021

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Jan 29, 2021

We cannot update the grpc beyond 1.29.1 until we bump etcd to 3.5.0, see
#13405 (comment), etcd-io/etcd#12124 and #14787 (comment) for more
information.

We also ignore github.com/miekg/dns because we use our own fork of it
via replace and it seems the long-term plan is to replace the DNS proxy
with Envoy, see #14790 (comment)

@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Jan 29, 2021
@tklauser tklauser requested a review from rolinh January 29, 2021 09:32
@tklauser tklauser requested a review from a team as a code owner January 29, 2021 09:32
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 29, 2021
@rolinh
Copy link
Member

rolinh commented Jan 29, 2021

No need for a full CI run as this PR only touches the dependabot config file.

@rolinh rolinh added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 29, 2021
@rolinh
Copy link
Member

rolinh commented Jan 29, 2021

@tklauser Would you mind updating the PR so that it also ignores github.com/miekg/dns? There's a replace directive with our fork of it. It seems the plan is anyway to replace the DNS proxy with Envoy as per @aanm.

We cannot update the grpc beyond 1.29.1 until we bump etcd to 3.04, see
cilium#13405 (comment),
etcd-io/etcd#12124 and
cilium#14787 (comment) for
more information.

We also ignore github.com/miekg/dns because we use our own fork of it
via replace and it seems the long-term plan is to replace the DNS proxy
with Envoy, see
cilium#14790 (comment)

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser force-pushed the pr/tklauser/dependabot-ignore-grpc branch from 3569669 to 70cb16c Compare January 29, 2021 11:45
@tklauser
Copy link
Member Author

github.com/miekg/dns

Sure, done.

@tklauser tklauser changed the title dependabot: ignore grpc updates dependabot: ignore grpc and mikg/dns updates Jan 29, 2021
@tklauser tklauser changed the title dependabot: ignore grpc and mikg/dns updates dependabot: ignore grpc and miekg/dns updates Jan 29, 2021
@aanm aanm merged commit d617f73 into cilium:master Jan 30, 2021
@tklauser tklauser deleted the pr/tklauser/dependabot-ignore-grpc branch February 1, 2021 10:01
lyveng pushed a commit to lyveng/cilium that referenced this pull request Mar 4, 2021
We cannot update the grpc beyond 1.29.1 until we bump etcd to 3.04, see
cilium#13405 (comment),
etcd-io/etcd#12124 and
cilium#14787 (comment) for
more information.

We also ignore github.com/miekg/dns because we use our own fork of it
via replace and it seems the long-term plan is to replace the DNS proxy
with Envoy, see
cilium#14790 (comment)

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants