Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updates steps when using submit-backport #14799

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

pchaigno
Copy link
Member

The submit-backport script takes care of pushing the local branch to the remote repository. So, when using that script, the push step is unnecessary.

The submit-backport script takes care of pushing the local branch to the
remote repository. So, when using that script, the push step is
unnecessary.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools. labels Jan 29, 2021
@pchaigno pchaigno requested review from a team as code owners January 29, 2021 16:06
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Jan 29, 2021
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on the patch.

One question: Should we replace origin by something indicating that people should push to their own fork instead?

@pchaigno
Copy link
Member Author

One question: Should we replace origin by something indicating that people should push to their own fork instead?

If using a fork, I would expect origin to point to the fork and upstream to cilium/cilium.

@qmonnet qmonnet removed their assignment Jan 29, 2021
@aanm
Copy link
Member

aanm commented Jan 30, 2021

One question: Should we replace origin by something indicating that people should push to their own fork instead?

If using a fork, I would expect origin to point to the fork and upstream to cilium/cilium.

Is that something that can be detect? For example I use origin for the cilium/cilium and something else for aanm/cilium

@pchaigno
Copy link
Member Author

pchaigno commented Feb 1, 2021

One question: Should we replace origin by something indicating that people should push to their own fork instead?

If using a fork, I would expect origin to point to the fork and upstream to cilium/cilium.

Is that something that can be detect? For example I use origin for the cilium/cilium and something else for aanm/cilium

Yes. IIRC we even already perform this sort of detection in some other script, so shouldn't be too hard to do the same in submit-backport as well.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 2, 2021
@tklauser tklauser merged commit afa3d67 into master Feb 2, 2021
@tklauser tklauser deleted the pr/pchaigno/update-backport-docs branch February 2, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants