test: Always select nodes by label #14867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node name for nodes in e.g. GKE is not fixed as in Packet nodes. So selecting nodes based on their name, as done in GetCiliumPodOnNode doesn't work there. This commit renames GetCiliumPodOnNode to GetCiliumPodOnNodeWithLabels and ensures we always select nodes by label in tests. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
area/CI-improvement
|
test-me-please |
tklauser
approved these changes
Feb 5, 2021
kkourt
approved these changes
Feb 8, 2021
|
This pull request is not touching any SIG-specific code, but only ci-structure's. So I think we're ready to merge without the last few team reviews. |
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node name for nodes in e.g. GKE is not fixed as in Packet nodes. So selecting nodes based on their name, as done in
GetCiliumPodOnNodedoesn't work there. This commit renamesGetCiliumPodOnNodetoGetCiliumPodOnNodeWithLabelsand ensures we always select nodes by label in tests.