Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in grpc example #14874

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Fix typo in grpc example #14874

merged 1 commit into from
Feb 9, 2021

Conversation

teyuchang
Copy link
Contributor

@teyuchang teyuchang commented Feb 5, 2021 •
edited

Signed-off-by: Te-Yu Chang dale.teyuchang@gmail.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fix typo in grpc example
cc-door-sgr -> cc-door-mgr

@teyuchang
Fix typo in grpc example
60fe5c3 
Signed-off-by: Te-Yu Chang <dale.teyuchang@gmail.com>
@teyuchang teyuchang requested a review from a team as a code owner February 5, 2021 22:42
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 5, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Feb 5, 2021
@sayboras sayboras added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Feb 6, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 6, 2021
qmonnet
qmonnet approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks a lot!

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 8, 2021
@teyuchang
Copy link
Contributor Author

The following tests are marked as required, but there are no corresponding Github Action jobs for them.
It leads to indefinite waiting.

Cilium-Ginkgo-GKE
K8s-1.13-Kernel-netnext
K8s-1.19-Kernel-4.19
K8s-1.20-kernel-4.9
Runtime-4.9

@aanm aanm merged commit 42294ba into cilium:master Feb 9, 2021
@teyuchang teyuchang deleted the fix-typo branch February 9, 2021 14:29
@joestringer joestringer moved this from In progress to Done in 1.10.0 Feb 12, 2021
@joestringer joestringer moved this from In progress to Done in 1.10.0 Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees

@qmonnet qmonnet

Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teyuchang @qmonnet @aanm @sayboras