datapath: Do not log when kernel config not found #14902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
area/daemon
aanm
approved these changes
Feb 9, 2021
Previously, when cilium-agent couldn't find a kernel config (a case for distros which do not expose the config via /proc/config.gz, but instead they store it in /boot, which is not mounted into a cilium container), we logged the following message: level=info msg="BPF system config check: NOT OK." error="Kernel Config file not found" subsys=linux-datapath This confused users making them to think that the missing kernel config was to blame for their connectivity issues. Thus, this commit silences the message (missing CONFIG_BPF would anyway result in non-cryptic error message). We can bring the message back once #14314 has been resolved. Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
force-pushed
the
pr/brb/rm-kernel-config-check
branch
from
e4b464b
to
1a0347d
Compare
jibi
approved these changes
Feb 16, 2021
|
test-me-please |
|
test-gke |
|
retest-4.19 |
|
retest-gke |
|
@jibi with small changes like these there is no need to make all tests pass. |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.5
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when cilium-agent couldn't find a kernel config (a case for
distros which do not expose the config via /proc/config.gz, but instead
they store it in /boot, which is not mounted into a cilium container),
we logged the following message:
This confused users making them to think that the missing kernel config
was to blame for their connectivity issues. Thus, this commit silences
the message (missing CONFIG_BPF would anyway result in a non-cryptic error
message).
We can bring the message back once #14314 has been resolved.