ipam/aws: updated EC2 instances ENI limits and added an helper function to make it easier to do so in the future #14906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joestringer
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
aanm
approved these changes
Feb 16, 2021
tgraf
approved these changes
Mar 8, 2021
|
test-me-please |
|
@mvisonneau can you rebase this PR against master so that we can run the CI? thanks! |
aanm
added
the
dont-merge/needs-rebase
mvisonneau
force-pushed
the
update_ec2_limits
branch
from
dfe5b64
to
8212f18
Compare
|
there you go @aanm! 👍 |
|
test-me-please |
aanm
removed
the
dont-merge/needs-rebase
|
@mvisonneau can you make the commit message title shorter? 🙏 |
In this change, I also added an helper function as a comment to make it easier to update in the future. Signed-off-by: Maxime VISONNEAU <maxime.visonneau@gmail.com>
mvisonneau
force-pushed
the
update_ec2_limits
branch
from
8212f18
to
bda40fd
Compare
|
absolutely, I need to workout my commit descriptions 😅 👍 |
|
test-me-please |
pchaigno
added
area/eni
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of the fix for #14802
On top of #14905, this PR updates the hardcoded EC2 ENI limits to support newly added instance types. I also added as an inline comment the helper I used to recalculate this list dynamically.