.github: add GitHub actions to build images #14917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
release-note/misc
joestringer
approved these changes
Feb 9, 2021
| shell: bash | ||
| run: | | ||
| mkdir -p image-digest/ | ||
| echo "docker.io/${{ github.repository_owner }}/${{ matrix.name }}-dev:${{ steps.vars.outputs.tag }}@${{ steps.docker_build_release.outputs.digest }}" > image-digest/${{ matrix.name }}.txt |
There was a problem hiding this comment.
Would be kinda nice to add little section titles like we did for recent releases, just to make the output easier to read in the release notes:
aanm
force-pushed
the
pr/test-docker-images-legacy
branch
from
1a5691c
to
cfbc2f0
Compare
aanm
force-pushed
the
pr/test-docker-images-legacy
branch
from
cfbc2f0
to
2529c1d
Compare
These GH actions will be able to push images into quay.io/cilium/*-ci. In follow up PRs, Jenkins jobs and GH actions will stop building images and the GH action will push the images into quay.io making them available. Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/test-docker-images-legacy
branch
from
ad72638
to
a1d8193
Compare
nebril
approved these changes
Feb 10, 2021
christarazi
reviewed
Feb 10, 2021
| /.github/workflows/ @cilium/ci-structure | ||
| /.github/workflows/coccicheck.yaml @cilium/ci-structure @cilium/bpf | ||
| /.github/workflows/docs.yaml @cilium/ci-structure @cilium/docs-structure | ||
| /.github/workflows/images.yaml @cilium/ci-structure @cilium/build | ||
| /.github/workflows/ @cilium/maintainers |
There was a problem hiding this comment.
Why are these other codeowners removed? We can still assign specific files to specific codeowners, but the overall .github/workflows be managed by cilium/maintainers (which you already have right now)
There was a problem hiding this comment.
we can't have specific files to be assigned to different teams, all of the .github workflows need to be seem by maintainers.
This was referenced Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These GH actions will be able to push images into quay.io/cilium/*-ci.
In follow up PRs, Jenkins jobs and GH actions will stop building images
and the GH action will push the images into quay.io making them
available.
Signed-off-by: André Martins andre@cilium.io
With this PR
quay.io/cilium/*-ci:latestwill contain the latest changes from master branch.@joestringer @christarazi for the next release (doesn't matter the tag) we will do a dry-run and publish the images in
quay.io/cilium/*-dev. If that is successful we will move to the real repositories. Sounds good?Follow up GH issue: #14928
edit, output of the digests for the release GH action:
cilium
docker.io/cilium/cilium-dev:test-docker-images-legacy@sha256:de6003244ceef3c52da8e186cff6fda2fa3533c74af7a149b3b1e4ff1329ce8dquay.io/cilium/cilium-dev:test-docker-images-legacy@sha256:de6003244ceef3c52da8e186cff6fda2fa3533c74af7a149b3b1e4ff1329ce8dclustermesh-apiserver
docker.io/cilium/clustermesh-apiserver-dev:test-docker-images-legacy@sha256:8e8e6eb7f2ed75e402f0d5bbe265fb50bd47502a601858c4c3b7cd7e630d5540quay.io/cilium/clustermesh-apiserver-dev:test-docker-images-legacy@sha256:8e8e6eb7f2ed75e402f0d5bbe265fb50bd47502a601858c4c3b7cd7e630d5540docker-plugin
docker.io/cilium/docker-plugin-dev:test-docker-images-legacy@sha256:a0445eac6738adca9693baf7a33bfb8251467f3a5a377467810c6b42d9a96252quay.io/cilium/docker-plugin-dev:test-docker-images-legacy@sha256:a0445eac6738adca9693baf7a33bfb8251467f3a5a377467810c6b42d9a96252hubble-relay
docker.io/cilium/hubble-relay-dev:test-docker-images-legacy@sha256:d1dba2f62d9d5fb41169cbb1f412e0e565708c9848c11c6acb300904491c68b8quay.io/cilium/hubble-relay-dev:test-docker-images-legacy@sha256:d1dba2f62d9d5fb41169cbb1f412e0e565708c9848c11c6acb300904491c68b8operator-aws
docker.io/cilium/operator-aws-dev:test-docker-images-legacy@sha256:2ec42cc0d62315dfa1dcb440d71d09f9a660ce838e6dbd87ff0a5b37f99c1ef5quay.io/cilium/operator-aws-dev:test-docker-images-legacy@sha256:2ec42cc0d62315dfa1dcb440d71d09f9a660ce838e6dbd87ff0a5b37f99c1ef5operator-azure
docker.io/cilium/operator-azure-dev:test-docker-images-legacy@sha256:7e74d4787565e635728296357a98ca3a8ed2254b1461b2bc484baeab3246f3c7quay.io/cilium/operator-azure-dev:test-docker-images-legacy@sha256:7e74d4787565e635728296357a98ca3a8ed2254b1461b2bc484baeab3246f3c7operator-generic
docker.io/cilium/operator-generic-dev:test-docker-images-legacy@sha256:a711ec9b858862140e1a1086cff7a77b507a63abb3bff6e605e315677d2985cequay.io/cilium/operator-generic-dev:test-docker-images-legacy@sha256:a711ec9b858862140e1a1086cff7a77b507a63abb3bff6e605e315677d2985ceoperator
docker.io/cilium/operator-dev:test-docker-images-legacy@sha256:1aab307576cee0250778c5f24de1b206b1f51c153f5be1edb569195e9609999aquay.io/cilium/operator-dev:test-docker-images-legacy@sha256:1aab307576cee0250778c5f24de1b206b1f51c153f5be1edb569195e9609999a