Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: add GitHub actions to build images #14917

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Conversation

aanm
Copy link
Member

@aanm aanm commented Feb 9, 2021

These GH actions will be able to push images into quay.io/cilium/*-ci.
In follow up PRs, Jenkins jobs and GH actions will stop building images
and the GH action will push the images into quay.io making them
available.

Signed-off-by: André Martins andre@cilium.io

With this PR quay.io/cilium/*-ci:latest will contain the latest changes from master branch.

@joestringer @christarazi for the next release (doesn't matter the tag) we will do a dry-run and publish the images in quay.io/cilium/*-dev. If that is successful we will move to the real repositories. Sounds good?

Follow up GH issue: #14928

edit, output of the digests for the release GH action:

cilium

docker.io/cilium/cilium-dev:test-docker-images-legacy@sha256:de6003244ceef3c52da8e186cff6fda2fa3533c74af7a149b3b1e4ff1329ce8d
quay.io/cilium/cilium-dev:test-docker-images-legacy@sha256:de6003244ceef3c52da8e186cff6fda2fa3533c74af7a149b3b1e4ff1329ce8d

clustermesh-apiserver

docker.io/cilium/clustermesh-apiserver-dev:test-docker-images-legacy@sha256:8e8e6eb7f2ed75e402f0d5bbe265fb50bd47502a601858c4c3b7cd7e630d5540
quay.io/cilium/clustermesh-apiserver-dev:test-docker-images-legacy@sha256:8e8e6eb7f2ed75e402f0d5bbe265fb50bd47502a601858c4c3b7cd7e630d5540

docker-plugin

docker.io/cilium/docker-plugin-dev:test-docker-images-legacy@sha256:a0445eac6738adca9693baf7a33bfb8251467f3a5a377467810c6b42d9a96252
quay.io/cilium/docker-plugin-dev:test-docker-images-legacy@sha256:a0445eac6738adca9693baf7a33bfb8251467f3a5a377467810c6b42d9a96252

hubble-relay

docker.io/cilium/hubble-relay-dev:test-docker-images-legacy@sha256:d1dba2f62d9d5fb41169cbb1f412e0e565708c9848c11c6acb300904491c68b8
quay.io/cilium/hubble-relay-dev:test-docker-images-legacy@sha256:d1dba2f62d9d5fb41169cbb1f412e0e565708c9848c11c6acb300904491c68b8

operator-aws

docker.io/cilium/operator-aws-dev:test-docker-images-legacy@sha256:2ec42cc0d62315dfa1dcb440d71d09f9a660ce838e6dbd87ff0a5b37f99c1ef5
quay.io/cilium/operator-aws-dev:test-docker-images-legacy@sha256:2ec42cc0d62315dfa1dcb440d71d09f9a660ce838e6dbd87ff0a5b37f99c1ef5

operator-azure

docker.io/cilium/operator-azure-dev:test-docker-images-legacy@sha256:7e74d4787565e635728296357a98ca3a8ed2254b1461b2bc484baeab3246f3c7
quay.io/cilium/operator-azure-dev:test-docker-images-legacy@sha256:7e74d4787565e635728296357a98ca3a8ed2254b1461b2bc484baeab3246f3c7

operator-generic

docker.io/cilium/operator-generic-dev:test-docker-images-legacy@sha256:a711ec9b858862140e1a1086cff7a77b507a63abb3bff6e605e315677d2985ce
quay.io/cilium/operator-generic-dev:test-docker-images-legacy@sha256:a711ec9b858862140e1a1086cff7a77b507a63abb3bff6e605e315677d2985ce

operator

docker.io/cilium/operator-dev:test-docker-images-legacy@sha256:1aab307576cee0250778c5f24de1b206b1f51c153f5be1edb569195e9609999a
quay.io/cilium/operator-dev:test-docker-images-legacy@sha256:1aab307576cee0250778c5f24de1b206b1f51c153f5be1edb569195e9609999a

@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.7 labels Feb 9, 2021
@aanm aanm requested a review from a team as a code owner February 9, 2021 18:48
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Feb 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.5 Feb 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.7 Feb 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.7.14 Feb 9, 2021
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, how do we map the "legacy" workflows to certain branches?

Minor nits below, nothing blocking.

.github/workflows/images-legacy.yaml Show resolved Hide resolved
.github/workflows/images-legacy-releases.yaml Show resolved Hide resolved
shell: bash
run: |
mkdir -p image-digest/
echo "docker.io/${{ github.repository_owner }}/${{ matrix.name }}-dev:${{ steps.vars.outputs.tag }}@${{ steps.docker_build_release.outputs.digest }}" > image-digest/${{ matrix.name }}.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be kinda nice to add little section titles like we did for recent releases, just to make the output easier to read in the release notes:

https://github.com/cilium/cilium/releases/tag/v1.9.4

@aanm aanm force-pushed the pr/test-docker-images-legacy branch from 1a5691c to cfbc2f0 Compare February 10, 2021 14:18
@aanm aanm temporarily deployed to release February 10, 2021 14:18 Inactive
@aanm aanm temporarily deployed to release February 10, 2021 14:18 Inactive
@aanm aanm temporarily deployed to release February 10, 2021 14:18 Inactive
@aanm aanm temporarily deployed to release February 10, 2021 14:18 Inactive
@aanm aanm temporarily deployed to release February 10, 2021 14:18 Inactive
@aanm aanm temporarily deployed to release February 10, 2021 14:18 Inactive
@aanm aanm temporarily deployed to release February 10, 2021 14:18 Inactive
@aanm aanm temporarily deployed to release February 10, 2021 14:18 Inactive
@aanm aanm force-pushed the pr/test-docker-images-legacy branch from cfbc2f0 to 2529c1d Compare February 10, 2021 14:29
@aanm aanm temporarily deployed to release February 10, 2021 15:47 Inactive
@aanm aanm temporarily deployed to release February 10, 2021 15:47 Inactive
@aanm aanm temporarily deployed to release February 10, 2021 15:47 Inactive
@aanm aanm temporarily deployed to release February 10, 2021 15:47 Inactive
@aanm aanm temporarily deployed to release February 10, 2021 15:47 Inactive
@aanm aanm temporarily deployed to release February 10, 2021 15:47 Inactive
@aanm aanm temporarily deployed to release February 10, 2021 15:47 Inactive
These GH actions will be able to push images into quay.io/cilium/*-ci.
In follow up PRs, Jenkins jobs and GH actions will stop building images
and the GH action will push the images into quay.io making them
available.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm marked this pull request as ready for review February 10, 2021 17:44
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/test-docker-images-legacy branch from ad72638 to a1d8193 Compare February 10, 2021 17:46
@aanm aanm requested a review from a team as a code owner February 10, 2021 17:46
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.9.5 Feb 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.8.7 Feb 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.7.14 Feb 10, 2021
@aanm aanm requested a review from gandro February 10, 2021 17:49
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

.github/workflows/images-legacy.yaml Show resolved Hide resolved
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One question on the codeowners.

/.github/workflows/ @cilium/ci-structure
/.github/workflows/coccicheck.yaml @cilium/ci-structure @cilium/bpf
/.github/workflows/docs.yaml @cilium/ci-structure @cilium/docs-structure
/.github/workflows/images.yaml @cilium/ci-structure @cilium/build
/.github/workflows/ @cilium/maintainers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these other codeowners removed? We can still assign specific files to specific codeowners, but the overall .github/workflows be managed by cilium/maintainers (which you already have right now)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't have specific files to be assigned to different teams, all of the .github workflows need to be seem by maintainers.

@aanm aanm merged commit d87e9b6 into master Feb 11, 2021
@aanm aanm deleted the pr/test-docker-images-legacy branch February 11, 2021 09:56
@joestringer joestringer moved this from In progress to Done in 1.10.0 Feb 12, 2021
@joestringer joestringer moved this from In progress to Done in 1.10.0 Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants