-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Fix and add missing podLabels #14943
Conversation
Signed-off-by: Yurii Komar <IKOM@equinor.com>
@Subreptivus can you run the command |
Signed-off-by: Yurii Komar <IKOM@equinor.com>
Commit 373e9e125b22fea9d12510a9ff76e87f832a7196 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Can we get rid of the third commit (the merge, I suspect it was created because you tried to update the branch automatically in GitHub)? No need to update unless there are conflicts to solve, in which case it looks cleaner to rebase the PR on top on the current master.
Commit 373e9e125b22fea9d12510a9ff76e87f832a7196 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
1 similar comment
Commit 373e9e125b22fea9d12510a9ff76e87f832a7196 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Signed-off-by: Yurii Komar <IKOM@equinor.com>
@qmonnet Done, now it should be allright. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy now :). Thank you
test-me-please |
values
file were not propagated to actual manifestspodLabels
definition invalues
file and in actual manifests (i.e. certgen jobs Pods)