kpr: Make it possible to run bpf_sock on Kind #14951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
sig/datapath
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
brb
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
qmonnet
requested changes
Feb 12, 2021
brb
force-pushed
the
pr/brb/bpf-sock-on-kind
branch
from
0099cbc
to
c245867
Compare
|
@brb On newer kernels (at least with 5.10), Kind is broken on v1.9 with the recommended options (ie: |
@rolinh Good point, I will create a separate PR to update the docs. Meanwhile, could you create an issue for it so that I could link it in the docs? |
|
test-me-please |
brb
force-pushed
the
pr/brb/bpf-sock-on-kind
branch
from
c245867
to
ecb6ea1
Compare
aanm
requested changes
Feb 16, 2021
brb
force-pushed
the
pr/brb/bpf-sock-on-kind
branch
from
ecb6ea1
to
c3ebafc
Compare
brb
force-pushed
the
pr/brb/bpf-sock-on-kind
branch
from
c3ebafc
to
9399a49
Compare
When running on Kind, multiple cilium-agent instances running on the same host will try to attach to the same cgroup v2 root bpf_sock programs. As the LB BPF maps cannot be shared among them, in-cluster LB won't work. To fix this, we try to derive a cgroup v2 sub-hierarchy from a cilium-agent process cgroup v2. This guarantees, that each bpf_sock will be attached to a different cgroup. The net_cls and net_prio discrepancy when running with cgroup v2 was spotted by Daniel Borkmann. Signed-off-by: Martynas Pumputis <m@lambda.lt>
Signed-off-by: Martynas Pumputis <m@lambda.lt>
aanm
approved these changes
Feb 22, 2021
|
test-me-please |
|
test-net-next |
maintainer-s-little-helper
bot
added
the
ready-to-merge
christarazi
approved these changes
Feb 22, 2021
5 tasks
This was referenced Feb 24, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.5
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.5
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commit msgs.
Marked to be backported to v1.9, because this will resolve the BPF complexity issues when the host-reachable svc is disabled.
On lack of unit tests - unfortunately, we cannot control whether the unit tests will run on a host with or without cgroup v1 which can influence the results. Anyway, I'm planning to enable kpr test suite on Kind.