Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Quarantine test with secondary NodePort device #15003

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

pchaigno
Copy link
Member

The "from outside of cluster" section of that test is flaky (cf. #12511). We can therefore quarantine the test when it's running with the third node.

Related: #12511

The "from outside of cluster" section of that test is flaky
(cf. cilium#12511). We can therefore quarantine the test when it's running
with the third node.

Related: cilium#12511
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Feb 17, 2021
@pchaigno pchaigno requested a review from brb February 17, 2021 09:44
@pchaigno pchaigno requested a review from a team as a code owner February 17, 2021 09:44
@pchaigno pchaigno requested a review from a team February 17, 2021 09:44
@maintainer-s-little-helper maintainer-s-little-helper bot assigned brb and unassigned brb Feb 17, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Feb 17, 2021
@pchaigno
Copy link
Member Author

pchaigno commented Feb 17, 2021

Cluster scaling failed.
test-gke

@brb
Copy link
Member

brb commented Feb 17, 2021

Unfortunately, it won't completely eliminate flakes. Other NodePort BPF tests when requests are sent from outside flake too.

@pchaigno
Copy link
Member Author

Unfortunately, it won't completely eliminate flakes. Other NodePort BPF tests when requests are sent from outside flake too.

@brb They do flake sometimes, but clearly not as often: compare this dashboard for secondary device test to that one for all NodePort BPF tests (>10% vs. <1% failures on master).

@brb
Copy link
Member

brb commented Feb 18, 2021

OT: got it reproduced on local machines, but I don't have a clue yet why it the first request fails.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 18, 2021
@aanm aanm merged commit 288225a into cilium:master Feb 18, 2021
1.10.0 automation moved this from In progress to Done Feb 18, 2021
@pchaigno pchaigno deleted the quarantine-secondary-device-test branch February 18, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants