Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: Update required reviews #15009

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Feb 17, 2021

  • .github/workflows/ requires a review from maintainers as changes in that directory can have security implications. We should also request a review from the CI team as these files are part of CI after all.
  • Also request a review from @cilium/contributing on changes to CODEOWNERS.

.github/workflows/ requires a review from maintainers as changes in that
directory can have security implications. We should also request a review
from the CI team as these files are part of CI after all.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools. labels Feb 17, 2021
@pchaigno pchaigno requested a review from a team as a code owner February 17, 2021 14:08
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Feb 17, 2021
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno changed the title CODEOWNERS: Require reviews from CI team on GH actions CODEOWNERS: Update required reviews Feb 17, 2021
@pchaigno pchaigno requested review from a team and nebril and removed request for a team February 17, 2021 14:11
@nebril nebril added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 18, 2021
@nebril nebril removed their assignment Feb 18, 2021
@aanm aanm merged commit 3efd2df into cilium:master Feb 18, 2021
1.10.0 automation moved this from In progress to Done Feb 18, 2021
@pchaigno pchaigno deleted the request-ci-review-gha branch February 18, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants