Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.7 backports 2021-02-17 #15013

Closed
wants to merge 4 commits into from
Closed

v1.7 backports 2021-02-17 #15013

wants to merge 4 commits into from

Conversation

gandro
Copy link
Member

@gandro gandro commented Feb 17, 2021

Once this PR is merged, you can update the PR labels via:

$ for pr in 14893 14920 14338; do contrib/backporting/set-labels.py $pr done 1.7; done

joestringer and others added 4 commits February 17, 2021 16:49
[ upstream commit 463e0dc ]

Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
[ upstream commit 55caedc ]

Strictly speaking this is a general truth for all services, but we don't
have a dedicated section for explaining services and users have begun
reporting specifically in relation to AWS / ENI mode. Put this somewhere
in the docs, we can always move it around to somewhere more generic when
we have a better location for these links to live.

Signed-off-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
[ upstream commit 1e80ec0 ]

This commit updates the list of default label filters and clarifies the
default behavior, as well as how it changes when a first inclusive label
is added.

The example is also completed based on the new unit test added in the
previous commit.

Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
[ upstream commit 3b0f6e8 ]

Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
@gandro gandro requested a review from a team as a code owner February 17, 2021 15:58
@gandro gandro added backport/1.7 kind/backports This PR provides functionality previously merged into master. labels Feb 17, 2021
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change required for my backported PR.

====================================== =====================================================
Label Description
-------------------------------------- -----------------------------------------------------
``reserved:.*`` Include all ``reserved`` labels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That line can be dropped because #14114, which added it, wasn't backported to v1.7.

- k8s:k8s-app
- k8s:app
- k8s:name
- reserved:.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@gandro
Copy link
Member Author

gandro commented Feb 17, 2021

Closing this, as I realize I used the wrong script version to create this PR (c.f. #15008), and I want to make sure the scripts work as intended. I will address the changes by @pchaigno in the new PR. Sorry for the noise.

@gandro gandro closed this Feb 17, 2021
@gandro gandro deleted the pr/v1.7-backport-2021-02-17 branch February 17, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants