service: Skip upsert of service for disabled IP family #15026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
kind/bug
|
I need to add a unit test before merging. |
brb
approved these changes
Feb 19, 2021
|
Marking as "draft" while you prepare the testing side. When you would like additional review, scroll to the bottom of the page and click the "Ready for review" button. |
pchaigno
force-pushed
the
fix-ipv6-svc-panic
branch
from
6dc9d5d
to
5601b97
Compare
pchaigno
removed
the
dont-merge/blocked
The following panic can happen when trying to upsert e.g. an IPv6
service in the datapath when IPv6 is disabled in the agent. The
corresponding IPv6 lbmap doesn't exist so we get a nil pointer
reference.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1cd5900]
goroutine 147 [running]:
github.com/cilium/cilium/pkg/bpf.(*Map).OpenOrCreate(0x0, 0x0, 0x0, 0x0)
/go/src/github.com/cilium/cilium/pkg/bpf/map_linux.go:464 +0x40
github.com/cilium/cilium/pkg/maps/lbmap.updateRevNatLocked(0x2b1b5a0, 0xc000b365fc, 0x2b07380, 0xc000ae7e80, 0xc000b365f0, 0x1)
/go/src/github.com/cilium/cilium/pkg/maps/lbmap/lbmap.go:331 +0x68
github.com/cilium/cilium/pkg/maps/lbmap.(*LBBPFMap).UpsertService(0xc0009f5040, 0xc000b3a1e0, 0x0, 0xc000b47470)
/go/src/github.com/cilium/cilium/pkg/maps/lbmap/lbmap.go:130 +0x5b7
github.com/cilium/cilium/pkg/service.(*Service).upsertServiceIntoLBMaps(0xc00065a280, 0xc00066b420, 0x421e500, 0x0, 0x421e540, 0x0, 0x0, 0x421e540, 0x0, 0x0, ...)
/go/src/github.com/cilium/cilium/pkg/service/service.go:749 +0x3de
github.com/cilium/cilium/pkg/service.(*Service).UpsertService(0xc00065a280, 0xc000661a40, 0x0, 0x0, 0x0)
/go/src/github.com/cilium/cilium/pkg/service/service.go:324 +0xc85
github.com/cilium/cilium/pkg/k8s/watchers.(*K8sWatcher).addK8sSVCs(0xc000974480, 0xc0009a34c0, 0x1d, 0xc0009b2a96, 0x7, 0x0, 0xc000b22f30, 0xc00012be48, 0x10, 0x7ffff7fb9108)
/go/src/github.com/cilium/cilium/pkg/k8s/watchers/watcher.go:743 +0x47b
github.com/cilium/cilium/pkg/k8s/watchers.(*K8sWatcher).k8sServiceHandler.func1(0x0, 0xc0009a34c0, 0x1d, 0xc0009b2a96, 0x7, 0xc000b22f30, 0x0, 0xc00012be48, 0xc0009b0390)
/go/src/github.com/cilium/cilium/pkg/k8s/watchers/watcher.go:447 +0xbc7
github.com/cilium/cilium/pkg/k8s/watchers.(*K8sWatcher).k8sServiceHandler(0xc000974480)
/go/src/github.com/cilium/cilium/pkg/k8s/watchers/watcher.go:490 +0x95
created by github.com/cilium/cilium/pkg/k8s/watchers.(*K8sWatcher).RunK8sServiceHandler
/go/src/github.com/cilium/cilium/pkg/k8s/watchers/watcher.go:495 +0x3f
This commit fixes it by exiting early from UpsertService if trying to
upsert a service for an IP family that is disabled in the agent.
Fixes: cilium#15000
Fixes: cilium#14607
Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
fix-ipv6-svc-panic
branch
from
5601b97
to
c31fd99
Compare
pchaigno
requested review from
a team and
michi-covalent
and removed request for
a team
pchaigno
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.5
maintainer-s-little-helper
bot
removed
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.5
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following panic can happen when trying to upsert e.g. an IPv6 service in the datapath when IPv6 is disabled in the agent. The corresponding IPv6 lbmap doesn't exist so we get a nil pointer reference.
This commit fixes it by exiting early from
UpsertServiceif trying to upsert a service for an IP family that is disabled in the agent.Fixes: #15000
Fixes: #14607