daemon: don't install cilium-node-monitor symlink #15054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cilium-node-monitor was moved back into the agent in commit c0a86a3 ("monitor: Move cilium-node-monitor into cilium-agent"), so invoking the binary via the symlink no longer has any effect different from invoking the agent binary directly. It also seems, like we don't need to keep it for backwards compatibility e.g. on downgrade since this was already part of Cilium 1.6 which is no longer supported. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
added
kind/cleanup
errordeveloper
approved these changes
Feb 22, 2021
|
test-me-please |
christarazi
approved these changes
Feb 22, 2021
|
Received reviews from all affected teams and CI passed, marking as ready to merge. |
tklauser
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cilium-node-monitor was moved back into the agent in commit c0a86a3
("monitor: Move cilium-node-monitor into cilium-agent"), so invoking the
binary via the symlink no longer has any effect different from invoking
the agent binary directly. It also seems, like we don't need to keep it
for backwards compatibility e.g. on downgrade since this was already
part of Cilium 1.6 which is no longer supported.