images/cilium: set IMAGE_CROSS_TARGET_PLATFORM for right arch #15074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
the
release-note/misc
|
Looks like we need a cross arch |
errordeveloper
approved these changes
Feb 23, 2021
aanm
force-pushed
the
pr/fix-cilium-map-migrate
branch
from
7977a7f
to
d98fbb4
Compare
aanm
force-pushed
the
pr/fix-cilium-map-migrate
branch
from
d98fbb4
to
151523f
Compare
|
test-me-please |
aanm
force-pushed
the
pr/fix-cilium-map-migrate
branch
from
151523f
to
2ea28e7
Compare
|
test-me-please |
|
retest-gke |
tklauser
approved these changes
Feb 23, 2021
|
retest-1.20-4.9 (previous https://jenkins.cilium.io/job/Cilium-PR-K8s-1.20-kernel-4.9/753/) |
aanm
force-pushed
the
pr/fix-cilium-map-migrate
branch
from
2ea28e7
to
363b253
Compare
aanm
force-pushed
the
pr/fix-cilium-map-migrate
branch
from
363b253
to
34f5599
Compare
|
test-me-please |
Signed-off-by: André Martins <andre@cilium.io>
This variable is used to cross compile certain targets. Fixes the build of 'cilium-map-migrate' in multi-arch. Fixes: 706fc42 ("add multi-arch support into all images") Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/fix-cilium-map-migrate
branch
from
34f5599
to
dfca1a3
Compare
|
test-me-please |
joestringer
reviewed
Feb 24, 2021
There was a problem hiding this comment.
For the builder image side, this LGTM. We seem to add the arm64 compiler to the x86 image as well, but since we won't ship this image to user clusters I'm fine with that.
Looking at commit 68c961d however, we also recently removed the compilers image from the runtime side. What I'm expecting at a high level is that we build our own version of LLVM, strip it down so it only contains the bits necessary for BPF compilation, and we ship that compiler in the runtime image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable is used to cross compile certain targets. Fixes the build
of 'cilium-map-migrate' in multi-arch.
Fixes: 706fc42 ("add multi-arch support into all images")
Signed-off-by: André Martins andre@cilium.io
Fixes: #15073