Drop GODEBUG='madvdontneed=1' setting with Go 1.16 #15076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
the
release-note/misc
Go 1.16 switched back to madvdontneed=1 by default, see https://golang.org/doc/go1.16#runtime. Thus we no longer need to set this explicitly at runtime after switching to Go 1.16. This reverts the GODEBUG setting introduced by commit 83cb610 ("Makefile: build Cilium with madvdontneed=1") Fixes: 0cf2cff ("Update Go to 1.16") Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
tklauser
force-pushed
the
pr/tklauser/drop-madvdontneed
branch
from
2473d91
to
3af1658
Compare
aanm
approved these changes
Feb 23, 2021
|
test-me-please |
christarazi
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.16 switched back to
madvdontneed=1by default, seehttps://golang.org/doc/go1.16#runtime. Thus we no longer need to set
this explicitly at runtime after switching to Go 1.16 in commit
0cf2cff
("Update Go to 1.16")This reverts the
GODEBUGsetting introduced by commit 83cb610("Makefile: build Cilium with madvdontneed=1")