make: add help target to root Makefile for printing info about availble targets #15087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fristonio
added
area/misc
christarazi
requested changes
Feb 24, 2021
|
Super cool! Won't have to reference multiple guides to find a build target now. Could you also add
[1] https://github.com/cilium/cilium/blob/master/Makefile#L7 |
|
@aditighag It would also be good to mention that it doesn't strip the binaries of debug symbols as well. |
fristonio
force-pushed
the
pr/fristonio/make-help-target
branch
from
117e552
to
a4ea580
Compare
twpayne
reviewed
Feb 24, 2021
fristonio
force-pushed
the
pr/fristonio/make-help-target
branch
from
a4ea580
to
f1b509d
Compare
christarazi
approved these changes
Feb 24, 2021
fristonio
force-pushed
the
pr/fristonio/make-help-target
branch
from
f1b509d
to
3bd16ee
Compare
sayboras
approved these changes
Feb 24, 2021
fristonio
force-pushed
the
pr/fristonio/make-help-target
branch
from
3bd16ee
to
bb5e04b
Compare
tklauser
reviewed
Feb 25, 2021
There was a problem hiding this comment.
Nice work, this is really helpful 🚀
Some spelling consistency suggestions inline, mainly s/golang/Go as per https://golang.org/doc/faq#go_or_golang
fristonio
force-pushed
the
pr/fristonio/make-help-target
branch
from
bb5e04b
to
7b14328
Compare
…ble targets Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com>
fristonio
force-pushed
the
pr/fristonio/make-help-target
branch
from
7b14328
to
80aadba
Compare
fristonio
added
the
ready-to-merge
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new help target to the root Makefile that can be used to print information about the available targets from the Makefile. This can be pretty useful given the large number of make targets we have.
Sample: