Optimize Label.String() #15089
Merged
Optimize Label.String() #15089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
Could you update with benchmem too? |
glibsm
reviewed
Feb 24, 2021
michi-covalent
force-pushed
the
pr/michi/labelstr
branch
2 times, most recently
from
06d560f
to
f7ad702
Compare
michi-covalent
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
michi-covalent
requested review from
a team and
glibsm
and removed request for
a team
aanm
approved these changes
Feb 25, 2021
aanm
reviewed
Feb 25, 2021
aanm
reviewed
Feb 25, 2021
|
Since we're not scrambling the value each loop, hopefully there are no compiler optimizations skewing the results. |
glibsm
approved these changes
Feb 25, 2021
christarazi
approved these changes
Feb 25, 2021
Currently Hubble calls Label.String() for each label in every flow. This PR micro-optimizes Label.String() by using the plus operator instead of fmt.Sprintf. ``` // Before BenchmarkLabel_String-8 5566522 214 ns/op 96B/op 4 allocs/op // After BenchmarkLabel_String-8 19522693 60.6 ns/op 48 B/op 1 allocs/op ``` Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/labelstr
branch
from
f7ad702
to
fa133de
Compare
|
test-me-please |
1 similar comment
|
test-me-please |
nathanjsweet
approved these changes
Mar 4, 2021
pchaigno
added
sig/hubble
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Hubble calls Label.String() for each label in every flow. This
PR micro-optimizes Label.String() by using the plus operator instead of
fmt.Sprintf.
Signed-off-by: Michi Mutsuzaki michi@isovalent.com