checkpatch: update image (skip backports, add a check, suppress one report type) #15096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
added
area/CI
aanm
requested changes
Feb 24, 2021
qmonnet
force-pushed
the
pr/checkpatch_update
branch
from
74a0a1d
to
d02bf92
Compare
|
I have been made aware of another issue to fix on the checkpatch image, I'll update the image once more and then update this PR. |
qmonnet
force-pushed
the
pr/checkpatch_update
branch
from
d02bf92
to
eebaa08
Compare
|
Now ready for review again, I updated the test PRs too. |
gandro
approved these changes
Feb 25, 2021
aanm
approved these changes
Feb 25, 2021
aanm
requested changes
Feb 25, 2021
qmonnet
added
dont-merge/blocked
qmonnet
force-pushed
the
pr/checkpatch_update
branch
2 times, most recently
from
52fd318
to
f26ccea
Compare
aanm
reviewed
Feb 25, 2021
Update the checkpatch image tag (and switch to quay.io) to benefit from the following changes: - Skip checkpatch validation on backport branches - Suppress reports of type COMMIT_LOG_LONG_LINE - Add a repo-wide check on commit subject length - Use $GITHUB_REPOSITORY variable when retrieving commits For skipping backports we could instead update the conditions for running the job in the current repo, but that would be troublesome if we want to mark the action as required in the future. Therefore, we delegate the decision to the shell script in the checkpatch image: it returns early if a PR is not based on the 'master' branch. Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
force-pushed
the
pr/checkpatch_update
branch
from
f26ccea
to
cee1dbc
Compare
pchaigno
approved these changes
Feb 26, 2021
We could. I don't know if it's worth it, there's only one check that extends to all commit, the majority is still for bpf/. Do you have a suggestion? I'd rather avoid creating a new action just for that. |
aanm
approved these changes
Feb 26, 2021
Yeah, we have too many actions already... Let's postpone. |
pchaigno
added
the
ready-to-merge
This was referenced Mar 1, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.5
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the checkpatch image tag (and switch to quay.io) to benefit from the following changes:
COMMIT_LOG_LONG_LINEFor skipping backports we could instead update the conditions for running the job in the current repo, but that would be troublesome if we want to mark the action as required in the future. Therefore, we delegate the decision to the shell script in the checkpatch image: it returns early if a PR is not based on the 'master' branch.
Checkpatch updates available at https://github.com/cilium/image-tools/pull/104/files and https://github.com/cilium/image-tools/pull/109/files.
Tested here for the new check and the suppressed report, and there for skipping the backports.
Marking for backports for 1.9, where the checkpatch action is run but where we want to skip it.
No CI test needed, other than having the checkpatch verification still working.