Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node/manager: remove unused *Manager methods #15106

Merged
merged 1 commit into from
Feb 25, 2021
Merged

node/manager: remove unused *Manager methods #15106

merged 1 commit into from
Feb 25, 2021

Conversation

tklauser
Copy link
Member

DeleteAllNodes is unused since commit a71dfb4 ("pkg/k8s: use
official k8s library to watch events from kube-apiserver")

Exists is unused since commit 07312c6 ("pkg/{kvstore,node}: delay
node delete event in kvstore")

@tklauser
node/manager: remove unused *Manager methods
0666a57 
DeleteAllNodes is unused since commit a71dfb4 ("pkg/k8s: use
official k8s library to watch events from kube-apiserver")

Exists is unused since commit 07312c6 ("pkg/{kvstore,node}: delay
node delete event in kvstore")

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Feb 25, 2021
@tklauser tklauser requested a review from a team as a code owner February 25, 2021 10:48
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Feb 25, 2021
@tklauser
Copy link
Member Author

test-me-please

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 25, 2021
@christarazi christarazi merged commit 7a22cc5 into cilium:master Feb 25, 2021
1.10.0 automation moved this from In progress to Done Feb 25, 2021
@tklauser tklauser deleted the pr/tklauser/nodemanager-fixes branch February 25, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tklauser @christarazi @aanm