New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backporting: Update instructions for backporting workflow #15118
Merged
fristonio
merged 1 commit into
cilium:master
from
aditighag:pr/aditighag/backporting-instructions-update
Mar 1, 2021
Merged
backporting: Update instructions for backporting workflow #15118
fristonio
merged 1 commit into
cilium:master
from
aditighag:pr/aditighag/backporting-instructions-update
Mar 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 02320e added support for working with Cilium forks. Document the additional steps that are required with this new workflow. Additionally, workflow scope might be needed with the GitHub token in some cases that update the corresponding yamls - ``(refusing to allow a Personal Access Token to create or update workflow `.github/workflows/go-check.yaml` without `workflow` scope`` Signed-off-by: Aditi Ghag <aditi@cilium.io>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Feb 25, 2021
aditighag
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Feb 25, 2021
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Feb 25, 2021
christarazi
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
joestringer
approved these changes
Feb 25, 2021
aditighag
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Feb 25, 2021
qmonnet
reviewed
Feb 26, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.5
Mar 2, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.8
Mar 3, 2021
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.8
Mar 3, 2021
maintainer-s-little-helper
bot
moved this from Backport pending to v1.8
to Backport done to v1.8
in 1.8.8
Mar 3, 2021
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.5
Mar 8, 2021
This was referenced Mar 10, 2021
Due to a mistake when updating the command for changing labels in a backport PR, this PR has NOT been backported to v1.7. Marking for backports again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 02320e added support for using backporting scripts with Cilium forks. Document the
additional steps that are required with this new workflow.
Additionally, workflow scope might be needed with the GitHub token in
some cases that update the corresponding yamls -
(refusing to allow a Personal Access Token to create or update workflow `.github/workflows/go-check.yaml` without `workflow` scope