Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backporting: Update instructions for backporting workflow #15118

Conversation

aditighag
Copy link
Member

@aditighag aditighag commented Feb 25, 2021

Commit 02320e added support for using backporting scripts with Cilium forks. Document the
additional steps that are required with this new workflow.

Additionally, workflow scope might be needed with the GitHub token in
some cases that update the corresponding yamls -

(refusing to allow a Personal Access Token to create or update workflow `.github/workflows/go-check.yaml` without `workflow` scope

Commit 02320e added support for working with Cilium forks. Document the
additional steps that are required with this new workflow.

Additionally, workflow scope might be needed with the GitHub token in
some cases that update the corresponding yamls -

``(refusing to allow a Personal Access Token to create or update workflow `.github/workflows/go-check.yaml` without `workflow` scope``

Signed-off-by: Aditi Ghag <aditi@cilium.io>
@aditighag aditighag requested review from a team as code owners February 25, 2021 21:53
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 25, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Feb 25, 2021
@aditighag aditighag added the release-note/misc This PR makes changes that have no direct user impact. label Feb 25, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 25, 2021
@aditighag aditighag requested a review from a team February 25, 2021 21:53
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.8 Feb 25, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.5 Feb 25, 2021
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aditighag aditighag added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 25, 2021
@fristonio fristonio merged commit 198fe64 into cilium:master Mar 1, 2021
1.10.0 automation moved this from In progress to Done Mar 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.5 Mar 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.8 Mar 3, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.8 Mar 3, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.8 Mar 3, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.5 Mar 8, 2021
@qmonnet
Copy link
Member

qmonnet commented Apr 14, 2021

Due to a mistake when updating the command for changing labels in a backport PR, this PR has NOT been backported to v1.7. Marking for backports again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.8
Backport done to v1.8
1.9.5
Backport done to v1.9
Development

Successfully merging this pull request may close these issues.

None yet

9 participants