vendor: bump etcd to v3.5.0 and grpc to v1.39.0 #15123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
added
the
release-note/misc
|
test-me-please |
rolinh
force-pushed
the
pr/rolinh/vendor-grpc-etcd
branch
3 times, most recently
from
05d6163
to
da41ef4
Compare
rolinh
changed the title
rolinh
force-pushed
the
pr/rolinh/vendor-grpc-etcd
branch
from
da41ef4
to
f087433
Compare
rolinh
changed the title
rolinh
force-pushed
the
pr/rolinh/vendor-grpc-etcd
branch
from
f087433
to
0e2fc97
Compare
rolinh
changed the title
rolinh
force-pushed
the
pr/rolinh/vendor-grpc-etcd
branch
from
0e2fc97
to
59c442b
Compare
rolinh
changed the title
|
test-me-please |
aanm
approved these changes
Jun 16, 2021
|
The Travis CI failure looks real, it's failing in |
|
test-runtime VM provisioning failure due to NFS locking issue: https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/5007/ |
rolinh
force-pushed
the
pr/rolinh/vendor-grpc-etcd
branch
from
59c442b
to
a7a1c39
Compare
A bug in the unit tests apparently. It should be fixed with #16596. Marking this PR as blocked until this other PR is merged and this one rebased. |
rolinh
force-pushed
the
pr/rolinh/vendor-grpc-etcd
branch
from
a7a1c39
to
b7bdb41
Compare
|
test-me-please |
tklauser
approved these changes
Jun 22, 2021
8 tasks
rolinh
force-pushed
the
pr/rolinh/vendor-grpc-etcd
branch
3 times, most recently
from
c6282f5
to
cecf40d
Compare
rolinh
changed the title
|
test-me-please |
aanm
added
the
dont-merge/needs-rebase
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
rolinh
force-pushed
the
pr/rolinh/vendor-grpc-etcd
branch
from
cecf40d
to
2c469a7
Compare
rolinh
removed
the
dont-merge/needs-rebase
|
test-me-please |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our version of grpc has been lagging behind for a while now because of the issue described in this comment. The etcd project has just released a version (albeit still marked
alphabeta at the moment) that fixes this issue and thus allows bumping grpc to a more recent version. The Hubble team has been desperately wanting to bump the grpc dependency for a while now mostly to be able to provide more useful error messages.