Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove leftovers of running own registry in GKE tests #15124

Merged

Conversation

tklauser
Copy link
Member

As of commit ce72454 ("ci: use quay.io images in gke builds") the
GKE tests no longer run their own registry. Remove any leftover scripts
and manifests related to running our own registry.

clean-local-registry-tag.sh is already unused since commit 9cbc151
("ci: Start separate registries for gke builds")

As of commit ce72454 ("ci: use quay.io images in gke builds") the
GKE tests no longer run their own registry. Remove any leftover scripts
and manifests related to running our own registry.

clean-local-registry-tag.sh is already unused since commit 9cbc151
("ci: Start separate registries for gke builds")

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added the release-note/ci This PR makes changes to the CI. label Feb 26, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Feb 26, 2021
@tklauser
Copy link
Member Author

test-gke

@tklauser tklauser marked this pull request as ready for review February 26, 2021 12:24
@tklauser tklauser requested a review from a team as a code owner February 26, 2021 12:24
@tklauser
Copy link
Member Author

test-me-please

@tklauser
Copy link
Member Author

Tested draft successfully on GKE. Now re-running to confirm this has no side effects on other CI jobs.

@christarazi christarazi added the kind/cleanup This includes no functional changes. label Feb 26, 2021
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@christarazi christarazi merged commit 0105ce3 into cilium:master Feb 26, 2021
1.10.0 automation moved this from In progress to Done Feb 26, 2021
@tklauser tklauser deleted the pr/tklauser/remove-unused-ci-scripts branch February 26, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants