Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: do not depend on TARGET for install-bash-completion #15147

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

aanm
Copy link
Member

@aanm aanm commented Mar 1, 2021

As it was done before 6fb045d ("Makefile: add install-bash-completion target")
the install target did not depend on TARGET. This fixes up the change to
have the same behavior as before.

Fixes: 6fb045d ("Makefile: add install-bash-completion target")
Signed-off-by: André Martins andre@cilium.io

@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Mar 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Mar 1, 2021
@aanm
Copy link
Member Author

aanm commented Mar 2, 2021

test-me-please

@aanm aanm marked this pull request as ready for review March 2, 2021 20:10
@aanm aanm requested review from a team as code owners March 2, 2021 20:10
@aanm aanm requested review from a team and twpayne March 2, 2021 20:10
Copy link
Contributor

@twpayne twpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would reword the commit message to be

Makefile: add install-bash-completion-only target

as after this change, the install-bash-completion still depends on TARGET.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 3, 2021
As it was done before 6fb045d ("Makefile: add install-bash-completion target")
the install target did not depend on TARGET. This fixes up the change to
have the same behavior as before the change.

Fixes: 6fb045d ("Makefile: add install-bash-completion target")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm merged commit 29da448 into cilium:master Mar 4, 2021
1.10.0 automation moved this from In progress to Done Mar 4, 2021
@aanm aanm deleted the pr/fix-up-targets branch March 4, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants