Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Unquarantine tunneling + endpoint routes test #15152

Merged
merged 1 commit into from
Mar 2, 2021
Merged

test: Unquarantine tunneling + endpoint routes test #15152

merged 1 commit into from
Mar 2, 2021

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Mar 1, 2021

Our tunneling + per-endpoint routes test was fixed by #14913. We can unquarantine it.

@pchaigno
test: Unquarantine tunneling + endpoint routes test
cb53a79 
Our tunneling + per-endpoint routes test was fixed by 2ceb386 ("iptables:
Fix incorrect SNAT bypass with endpoint routes and tunneling"). We can
unquarantine it.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Mar 1, 2021
@pchaigno pchaigno requested a review from a team March 1, 2021 18:11
@pchaigno pchaigno requested a review from a team as a code owner March 1, 2021 18:11
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Mar 1, 2021
@pchaigno pchaigno requested review from jrfastab and kkourt March 1, 2021 18:11
@maintainer-s-little-helper maintainer-s-little-helper bot assigned jrfastab and kkourt and unassigned kkourt Mar 1, 2021
@pchaigno
Copy link
Member Author

pchaigno commented Mar 1, 2021

test-me-please

@pchaigno
Copy link
Member Author

pchaigno commented Mar 1, 2021 •
edited

It was particularly flaky on k8s-all so triggering those as well to double check:
test-missed-k8s

@pchaigno
Copy link
Member Author

pchaigno commented Mar 2, 2021

k8s-1.14-kernel-4.9 failed with #15166 and #15141. Other tests are passing. Both team reviews are covered. Marking as ready to merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 2, 2021
@errordeveloper errordeveloper merged commit 9ff2b3d into cilium:master Mar 2, 2021
1.10.0 automation moved this from In progress to Done Mar 2, 2021
@pchaigno pchaigno deleted the unquarantine-vxlan-endpoint-routes-test branch March 2, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkourt kkourt kkourt approved these changes

@jrfastab jrfastab Awaiting requested review from jrfastab

Assignees

@kkourt kkourt

@jrfastab jrfastab

Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pchaigno @kkourt @errordeveloper @jrfastab