Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Remove microk8s.registry dependency #15157

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

joestringer
Copy link
Member

The "make microk8s" target used to depend on deploying the registry
addon into the microk8s cluster, but since commit 1eedfb3
("Makefile: Remove microk8s prepull script") we've just relied on
importing the image directly so the registry is no longer necessary.

The "make microk8s" target used to depend on deploying the registry
addon into the microk8s cluster, but since commit 1eedfb3
("Makefile: Remove microk8s prepull script") we've just relied on
importing the image directly so the registry is no longer necessary.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer requested a review from a team as a code owner March 1, 2021 23:17
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Mar 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Mar 1, 2021
@aanm aanm merged commit 9bcc821 into cilium:master Mar 3, 2021
1.10.0 automation moved this from In progress to Done Mar 3, 2021
@joestringer joestringer deleted the submit/microk8s-registry-dep branch March 3, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants