docs: Fix max. number of tail calls #15162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/documentation
pchaigno
commented
Mar 2, 2021
aanm
added
the
dont-merge/needs-rebase
pchaigno
force-pushed
the
fix-bpf-docs-33-tail-calls
branch
from
1a08903
to
ee43ea7
Compare
pchaigno
removed
the
dont-merge/needs-rebase
The Linux kernel allows for 33 chained tail calls, not 32 as currently documented. The difference comes from what looks like an off-by-one error that was then generalized to all JIT compilers [1]. 1 - https://lore.kernel.org/bpf/20191218095825.GA15840@Omicron/T/ Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
fix-bpf-docs-33-tail-calls
branch
from
ee43ea7
to
7e005f2
Compare
christarazi
approved these changes
Mar 2, 2021
pchaigno
added
the
ready-to-merge
This comment has been minimized.
This comment has been minimized.
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.5
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linux kernel allows for 33 chained tail calls, not 32 as currently documented. The difference comes from what looks like an off-by-one error that was then generalized to all JIT compilers. Our documentation is used as a reference for papers and blog posts, so let's make sure this incorrect assumption doesn't propagate further.
Yoann, if you're reading this, the source code is the source of truth, not the documentation 馃槣