daemon: do not allow --auto-direct-node-routes when tunneling is enabled #15196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
Enabling --auto-direct-node-routes when tunneling is enabled can cause traffic to leave the node through a physical interface (i.e. not encapsulated) rather than via the tunnel. Reported-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
jibi
force-pushed
the
pr/jibi/fatal-on-auto-direct-node-routes-with-tunneling
branch
from
80f0ebe
to
4d76779
Compare
jibi
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
jibi
added
area/daemon
borkmann
approved these changes
Mar 4, 2021
|
test-me-please |
pchaigno
approved these changes
Mar 4, 2021
qmonnet
approved these changes
Mar 4, 2021
|
Label-wise, is this a minor feature or a bug fix? |
|
I would say minor feature because it may affect users if they had incorrect flags in place. It's not a security bug, so let's remove the v1.8 backport. |
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.5
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.5
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling --auto-direct-node-routes when tunneling is enabled can cause
traffic to leave the node through a physical interface (i.e. not
encapsulated) rather than via the tunnel.
Reported-by: Paul Chaignon paul@cilium.io
Signed-off-by: Gilberto Bertin gilberto@isovalent.com