Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: Comment BPF hook points, some tail calls, and local delivery code #15204

Merged
merged 2 commits into from
Mar 17, 2021
Merged

bpf: Comment BPF hook points, some tail calls, and local delivery code #15204

merged 2 commits into from
Mar 17, 2021

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Mar 4, 2021

No description provided.

@pchaigno pchaigno added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Mar 4, 2021
@pchaigno pchaigno requested review from brb and a team March 4, 2021 13:23
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Mar 4, 2021
@pchaigno
Copy link
Member Author

pchaigno commented Mar 4, 2021

The checkpatch warning can be ignored (empty commit messages).

borkmann
borkmann reviewed Mar 5, 2021
View reviewed changes
bpf/lib/nodeport.h Outdated Show resolved Hide resolved
@pchaigno pchaigno requested a review from borkmann March 5, 2021 08:21
@pchaigno pchaigno requested a review from borkmann March 5, 2021 11:35
brb
brb reviewed Mar 8, 2021
View reviewed changes
bpf/lib/l3.h Outdated Show resolved Hide resolved
@pchaigno pchaigno requested a review from brb March 8, 2021 14:30
@pchaigno pchaigno unassigned brb Mar 9, 2021
christarazi
christarazi approved these changes Mar 11, 2021
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, one minor point about the referring to "pod"

bpf/lib/l3.h Show resolved Hide resolved
borkmann
borkmann reviewed Mar 15, 2021
View reviewed changes
bpf/bpf_lxc.c Outdated Show resolved Hide resolved
@pchaigno
bpf: Add a few comments in NAT handling code
6aa5218 
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno
bpf: Comment hook points and local delivery
85734a6 
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 16, 2021
@joestringer joestringer merged commit c803280 into cilium:master Mar 17, 2021
1.10.0 automation moved this from In progress to Done Mar 17, 2021
@pchaigno pchaigno deleted the add-datapath-comments branch March 17, 2021 06:13
This was referenced Apr 28, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@borkmann borkmann borkmann approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pchaigno @brb @borkmann @christarazi @joestringer