Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: update iproute2 git URL in bpf.rst #15207

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Documentation: update iproute2 git URL in bpf.rst #15207

merged 1 commit into from
Mar 8, 2021

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Mar 4, 2021

PR fixes the git URL for iproute2 on https://docs.cilium.io/en/latest/bpf/#compiling-iproute2 - the current one doesn't work:

$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/iproute2/iproute2.git /tmp/iproute
Cloning into '/tmp/iproute'...
fatal: remote error: access denied or repository not exported: /pub/scm/linux/kernel/git/iproute2/iproute2.git

Changed it to the https:// URL from the bottom of https://git.kernel.org/pub/scm/network/iproute2/iproute2.git which works fine.

@dmitris
Documentation: update iproute2 git URL in bpf.rst
360c555 
Signed-off-by: Dmitry Savintsev <dsavints@verizonmedia.com>
@dmitris dmitris requested a review from a team March 4, 2021 14:58
@dmitris dmitris requested a review from a team as a code owner March 4, 2021 14:58
@dmitris dmitris requested review from jrfastab and qmonnet March 4, 2021 14:58
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 4, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Mar 4, 2021
@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Mar 4, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 4, 2021
qmonnet
qmonnet approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@qmonnet qmonnet removed the request for review from jrfastab March 4, 2021 15:42
@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 4, 2021
@dmitris
Copy link
Contributor Author

dmitris commented Mar 4, 2021

sorry, @qmonnet could you hold off on a merge for a bit? (Need to complete an internal approval procedure on my side since it's my first PR to this project and repository - expect to be back with a "go ahead" shortly). Thanks.

@pchaigno pchaigno removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 4, 2021
@qmonnet qmonnet added the dont-merge/blocked Another PR must be merged before this one. label Mar 4, 2021
@dmitris
Copy link
Contributor Author

dmitris commented Mar 5, 2021

all clear now - please go ahead and merge! Thanks. @qmonnet

@pchaigno pchaigno added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. and removed dont-merge/blocked Another PR must be merged before this one. labels Mar 5, 2021
@errordeveloper errordeveloper merged commit 6986c55 into cilium:master Mar 8, 2021
1.10.0 automation moved this from In progress to Done Mar 8, 2021
@dmitris dmitris deleted the iproute-git-url branch March 8, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dmitris @pchaigno @qmonnet @errordeveloper @jrfastab