Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix commands to build dev. docker images #15231

Merged
merged 1 commit into from
Mar 8, 2021
Merged

docs: Fix commands to build dev. docker images #15231

merged 1 commit into from
Mar 8, 2021

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Mar 5, 2021

Fixes: #15023

@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools. labels Mar 5, 2021
@pchaigno pchaigno requested review from a team as code owners March 5, 2021 22:37
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Mar 5, 2021
@pchaigno
docs: Fix commands to build dev. docker images
9458ab2 
Fixes: bc7945d ("build: Fix buildx use")
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno requested a review from aditighag March 8, 2021 10:21
@qmonnet qmonnet removed their assignment Mar 8, 2021
@tklauser tklauser removed their assignment Mar 8, 2021
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 8, 2021
@aanm aanm merged commit b658690 into cilium:master Mar 8, 2021
1.10.0 automation moved this from In progress to Done Mar 8, 2021
@pchaigno pchaigno deleted the fix-docs-dev-image-builds branch March 8, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@qmonnet qmonnet qmonnet approved these changes

@aditighag aditighag Awaiting requested review from aditighag

Assignees

@aditighag aditighag

Labels
area/CI Continuous Integration testing issue or flake area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pchaigno @tklauser @qmonnet @aditighag @aanm