Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install/kubernetes: remove quick-install from master branches #15250

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

aanm
Copy link
Member

@aanm aanm commented Mar 8, 2021

Since :latest tags are no longer available in the docker image
repositories, we will remove the quick-install.yaml from the master
branch. However, this will still be valid for stable branches so we will
keep the GH action to still run on those branches.

Signed-off-by: André Martins andre@cilium.io

Since `:latest` tags are no longer available in the docker image
repositories, we will remove the quick-install.yaml from the master
branch. However, this will still be valid for stable branches so we will
keep the GH action to still run on those branches.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Mar 8, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Mar 8, 2021
@aanm
Copy link
Member Author

aanm commented Mar 8, 2021

test-me-please

@aanm
Copy link
Member Author

aanm commented Mar 9, 2021

test-1.20-4.9

@aanm aanm marked this pull request as ready for review March 9, 2021 09:31
@aanm aanm requested review from a team as code owners March 9, 2021 09:31
@aanm aanm requested a review from a team March 9, 2021 09:31
@aanm aanm requested a review from a team as a code owner March 9, 2021 09:31
@aanm aanm requested review from nebril and joestringer March 9, 2021 09:31
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@aanm aanm merged commit 1ef1dd5 into cilium:master Mar 9, 2021
1.10.0 automation moved this from In progress to Done Mar 9, 2021
@dghubble
Copy link
Contributor

dghubble commented Mar 9, 2021

These were useful as a reference 😢

@joestringer
Copy link
Member

@dghubble do you particularly need to reference the latest development versions of the quick-install? The most recent stable branch should still have these and we will continue to generate them for the supported stable releases at URLs like this:

https://github.com/cilium/cilium/blob/v1.9/install/kubernetes/quick-install.yaml

@joestringer
Copy link
Member

@aanm btw, this PR broke the quick-install link on this docs page:
https://docs.cilium.io/en/latest/gettingstarted/k8s-install-default/#install-cilium

@dghubble
Copy link
Contributor

dghubble commented Mar 9, 2021

@joestringer It was sometimes nice to see exactly the PR where something changed in those files, but per release seems pretty reasonable to reference or link to. Thanks

@joestringer
Copy link
Member

@dghubble another similar approach would be to look at the Helm charts readme, you can track the PRs for specific changes there in a similar way: https://github.com/cilium/cilium/blame/master/install/kubernetes/cilium/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants