Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change accees of go dir in test vm #15265

Merged
merged 2 commits into from
Mar 11, 2021
Merged

test: change accees of go dir in test vm #15265

merged 2 commits into from
Mar 11, 2021

Conversation

nebril
Copy link
Member

@nebril nebril commented Mar 9, 2021

This directory had some subdirs that belonged to root, which caused upstream tests to fail

@nebril nebril requested a review from a team as a code owner March 9, 2021 13:06
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Mar 9, 2021
@nebril nebril requested a review from nbusseneau March 9, 2021 13:06
@nebril
Copy link
Member Author

nebril commented Mar 9, 2021

test-k8s-upstream

@nebril nebril marked this pull request as draft March 9, 2021 13:28
@nebril nebril changed the title ci: explicitely set $HOME in upstream jenkinsfile test: change owner of go dir in test vm Mar 9, 2021
@nebril
Copy link
Member Author

nebril commented Mar 9, 2021

test-k8s-upstream

@nebril
Copy link
Member Author

nebril commented Mar 9, 2021

test-upstream-k8s

@nebril
Copy link
Member Author

nebril commented Mar 9, 2021

test-k8s-upstream

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril
Copy link
Member Author

nebril commented Mar 9, 2021

test-k8s-upstream

@nebril
Copy link
Member Author

nebril commented Mar 10, 2021

test-upstream-k8s

upstream tests want to create a directory in a root owned dir (which is
owned by root for some reason). Chown is not possible on jenkins nodes,
so chmod is used to allow vms to manipulate the code dir

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril
Copy link
Member Author

nebril commented Mar 10, 2021

test-upstream-k8s

@nebril
Copy link
Member Author

nebril commented Mar 10, 2021

test-me-please

@nebril nebril added the release-note/ci This PR makes changes to the CI. label Mar 10, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 10, 2021
@nebril nebril changed the title test: change owner of go dir in test vm test: change accees of go dir in test vm Mar 10, 2021
@nebril nebril marked this pull request as ready for review March 10, 2021 13:15
@nebril
Copy link
Member Author

nebril commented Mar 10, 2021

test-1.19-4.19

1 similar comment
@nebril
Copy link
Member Author

nebril commented Mar 10, 2021

test-1.19-4.19

Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird it was working before, but w/e.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 10, 2021
@aanm aanm merged commit 912792b into master Mar 11, 2021
1.10.0 automation moved this from In progress to Done Mar 11, 2021
@aanm aanm deleted the pr/fix-upstream-home branch March 11, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants