-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: change accees of go dir in test vm #15265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Mar 9, 2021
test-k8s-upstream |
nebril
force-pushed
the
pr/fix-upstream-home
branch
from
March 9, 2021 19:01
a5b5cd4
to
df2bed3
Compare
nebril
changed the title
ci: explicitely set $HOME in upstream jenkinsfile
test: change owner of go dir in test vm
Mar 9, 2021
test-k8s-upstream |
test-upstream-k8s |
test-k8s-upstream |
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
nebril
force-pushed
the
pr/fix-upstream-home
branch
from
March 9, 2021 21:02
b3f735c
to
fc8d3cd
Compare
test-k8s-upstream |
test-upstream-k8s |
upstream tests want to create a directory in a root owned dir (which is owned by root for some reason). Chown is not possible on jenkins nodes, so chmod is used to allow vms to manipulate the code dir Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
test-upstream-k8s |
test-me-please |
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Mar 10, 2021
nebril
changed the title
test: change owner of go dir in test vm
test: change accees of go dir in test vm
Mar 10, 2021
test-1.19-4.19 |
1 similar comment
test-1.19-4.19 |
nbusseneau
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's weird it was working before, but w/e.
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This directory had some subdirs that belonged to root, which caused upstream tests to fail