Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gettingstarted: Corrected typos in memcached.rst #15277

Merged
merged 1 commit into from
Mar 10, 2021
Merged

gettingstarted: Corrected typos in memcached.rst #15277

merged 1 commit into from
Mar 10, 2021

Conversation

unixdaddy
Copy link
Contributor

@unixdaddy unixdaddy commented Mar 9, 2021 •
edited

Minor corrections to gettingstarted memcached example

Signed-off-by: darren mackintosh unixdaddy@gmail.com

@unixdaddy unixdaddy requested a review from a team as a code owner March 9, 2021 17:47
@unixdaddy unixdaddy requested a review from qmonnet March 9, 2021 17:47
@maintainer-s-little-helper

This comment has been minimized.

Sign in to view
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Mar 9, 2021
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Mar 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 9, 2021
@unixdaddy
Copy link
Contributor Author

updated with sign off

qmonnet
qmonnet approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, many thanks for the fix!

Could you please add the Signed-off-by: tag to your commit log message as explained at the URL above, and force-push your updated commit?

@unixdaddy
Copy link
Contributor Author

I will do tomorrow.

@unixdaddy
gettingstarted: Corrected typos in memcached.rst
e5b3ce7 
Signed-off-by: darren mackintosh unixdaddy@gmail.com
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 9, 2021
@unixdaddy
Copy link
Contributor Author

updated with signoff as part of the commit message

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 9, 2021
@kkourt kkourt merged commit f6806f8 into cilium:master Mar 10, 2021
1.10.0 automation moved this from In progress to Done Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@unixdaddy @pchaigno @qmonnet @kkourt